sedmor branch: bermslope and avalanching#995
Open
hrajagers wants to merge 2 commits into
Open
Conversation
This reverts commit f66c862.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates sediment-morphology behavior around berm-slope transport and dune avalanching, aiming to couple berm-slope limits into the dune avalanching logic and to make berm-slope nudging depend on wave direction when waves are active.
Changes:
- Use
bermslopeas the maximum wet slope for dune avalanching on links flagged bybermslopeindex. - Update berm-slope nudging to use wave direction (
phiwav) when waves are enabled (fallback to the previous approach when no waves). - Remove the initialization-time warning/reset that changed the default
WetSlopewhen dune avalanching is enabled.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/engines_gpl/dflowfm/packages/dflowfm_kernel/src/dflowfm_kernel/prepost/flow_sedmorinit.f90 |
Removes the automatic warning/reset of wetslope when dune avalanching is on. |
src/engines_gpl/dflowfm/packages/dflowfm_kernel/src/dflowfm_kernel/compute_sediment/duneaval.f90 |
Applies bermslope as slpmax for dune avalanching on berm-slope links when bermslopetransport is active. |
src/engines_gpl/dflowfm/packages/dflowfm_kernel/src/dflowfm_kernel/compute_sediment/bermslopenudging.f90 |
Introduces wave-direction-based berm-slope nudging and refactors the fix-factor application logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…plied here ... for all flow links without bermslopeindexbed or bermslopeindexsus set the multiplication with `frac` and `fixfac` is done in `fm_adjust_bedload`.
Member
Author
|
@jreyns Can you approve or provide further review comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
bermslopenudging: Effect of wave direction included in bermslope avalanchingduneaval: Usebermslopeinstead ofwetslopewhen bermslope is active, and usewetslopewhen wet and bermslope is not activeflow_sedmorinit: Due to the previous change, there is no more limit onwetslopewhen bermslope is activatedEvidence of the work done
<add video/figures if applicable>
Tests
<add testcase numbers if applicable, Issue number>
Documentation
<add description of changes if applicable, Issue number>
Issue link