Skip to content

feat: allow setting default camera direction #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Demizo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: allow setting default camera direction #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/config_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ class ConfigManager {
'reminderEndMinute': 0,
'defaultTemplate': -1,
'imageQuality': 90,
'useFrontCamera': false,
};

static final moodValueFieldMapping = {
Expand Down
2 changes: 2 additions & 0 deletions lib/l10n/intl_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@
"@settingsCustomAccentColor": {},
"settingsShowMarkdownToolbar": "Show Markdown Toolbar",
"@settingsShowMarkdownToolbar": {},
"settingsPreferFrontCamera": "Prefer front camera",
"@settingsPreferFrontCamera": {},
"settingsChangeMoodIcons": "Change Mood Icons",
"@settingsChangeMoodIcons": {},
"moodIconPrompt": "Enter an icon",
Expand Down
11 changes: 11 additions & 0 deletions lib/pages/settings_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,6 +693,17 @@ class _SettingsPageState extends State<SettingsPage> {
.setField("useMarkdownToolbar", value);
});
}),
if (Platform.isAndroid)
SettingsToggle(
title: AppLocalizations.of(context)!
.settingsPreferFrontCamera,
settingsKey: "useFrontCamera",
onChanged: (value) {
setState(() {
ConfigManager.instance
.setField("useFrontCamera", value);
});
}),
Padding(
padding: const EdgeInsets.only(top: 8.0),
child: Text(
Expand Down
47 changes: 24 additions & 23 deletions lib/widgets/entry_image_picker.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,23 +30,22 @@ class _EntryImagePickerState extends State<EntryImagePicker> {
builder: (BuildContext context) {
return AlertDialog(
title: Text(AppLocalizations.of(context)!.deletePhotoTitle),
actions: [
TextButton(
child: Text(MaterialLocalizations.of(context).deleteButtonTooltip),
onPressed: () async {
widget.onChangedImage(null);
Navigator.pop(context);
},

),
TextButton(
child: Text(MaterialLocalizations.of(context).cancelButtonLabel),
onPressed: () async {
Navigator.pop(context);
},

)
],
actions: [
TextButton(
child:
Text(MaterialLocalizations.of(context).deleteButtonTooltip),
onPressed: () async {
widget.onChangedImage(null);
Navigator.pop(context);
},
),
TextButton(
child: Text(MaterialLocalizations.of(context).cancelButtonLabel),
onPressed: () async {
Navigator.pop(context);
},
)
],
content: Text(AppLocalizations.of(context)!.deletePhotoDescription),
);
},
Expand All @@ -63,10 +62,13 @@ class _EntryImagePickerState extends State<EntryImagePicker> {

Future<void> _takePicture() async {
final picker = ImagePicker();
final cameraDirection = ConfigManager.instance.getField('useFrontCamera')
? CameraDevice.front
: CameraDevice.rear;
final pickedFile = await picker.pickImage(
source: ImageSource.camera,
imageQuality: ConfigManager.instance.getField('imageQuality')
);
source: ImageSource.camera,
preferredCameraDevice: cameraDirection,
imageQuality: ConfigManager.instance.getField('imageQuality'));

if (pickedFile != null) {
await saveImage(pickedFile);
Expand All @@ -76,9 +78,8 @@ class _EntryImagePickerState extends State<EntryImagePicker> {
Future<void> _choosePicture() async {
final picker = ImagePicker();
final pickedFile = await picker.pickImage(
source: ImageSource.gallery,
imageQuality: ConfigManager.instance.getField('imageQuality')
);
source: ImageSource.gallery,
imageQuality: ConfigManager.instance.getField('imageQuality'));

if (pickedFile != null) {
await saveImage(pickedFile);
Expand Down