Skip to content

[codex] Fix Fastify 5 dependency update#15

Merged
dankritz merged 2 commits into
mainfrom
codex/pr-14-fastify-fix
May 11, 2026
Merged

[codex] Fix Fastify 5 dependency update#15
dankritz merged 2 commits into
mainfrom
codex/pr-14-fastify-fix

Conversation

@dankritz
Copy link
Copy Markdown
Contributor

Summary

  • upgrades Fastify companion plugins to Fastify 5-compatible majors
  • wraps migration execution in a PostgreSQL advisory lock so API and worker startup cannot race on fresh databases
  • keeps Dependabot's fastify/fast-uri security bump from chore(deps): bump fast-uri and fastify #14 intact

Root cause

PR #14 bumped fastify to 5.8.5 but left the @fastify/* plugins on Fastify 4-compatible majors, causing plugin registration to fail during unit tests. The full-stack smoke test also exposed a startup race where the API and worker both ran migrations concurrently and collided while creating pgcrypto.

Validation

  • npm run typecheck
  • npm run lint
  • npm test
  • npm run build
  • python3 -m unittest skills/deploy-to-vibestack/scripts/vibestack_deploy_test.py
  • scripts/ci-full-stack-smoke.sh

dependabot Bot and others added 2 commits May 8, 2026 19:23
Bumps [fast-uri](https://github.com/fastify/fast-uri) to 3.1.2 and updates ancestor dependency [fastify](https://github.com/fastify/fastify). These dependencies need to be updated together.


Updates `fast-uri` from 3.1.0 to 3.1.2
- [Release notes](https://github.com/fastify/fast-uri/releases)
- [Commits](fastify/fast-uri@v3.1.0...v3.1.2)

Updates `fastify` from 4.29.1 to 5.8.5
- [Release notes](https://github.com/fastify/fastify/releases)
- [Commits](fastify/fastify@v4.29.1...v5.8.5)

---
updated-dependencies:
- dependency-name: fast-uri
  dependency-version: 3.1.2
  dependency-type: indirect
- dependency-name: fastify
  dependency-version: 5.8.5
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dankritz dankritz force-pushed the codex/pr-14-fastify-fix branch from 59c895c to 7274977 Compare May 11, 2026 05:19
@dankritz dankritz marked this pull request as ready for review May 11, 2026 05:23
@dankritz dankritz merged commit 9f649c0 into main May 11, 2026
4 of 5 checks passed
@dankritz dankritz deleted the codex/pr-14-fastify-fix branch May 11, 2026 05:23
@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented May 11, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • apps/api/package.json - Fastify plugin dependency updates
  • apps/api/src/migrate.ts - Migration locking mechanism

Reviewed by grok-code-fast-1 · 118,498 tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant