Open
Conversation
The latest version of spdlog (1.15) bundles a newer version of fmtlib, which removes its default formatting behavior for enum types. Enum values must now either have a formatter specialization declared or be wrapped in a call to fmt::underlying() to print them as integers. (The previous behavior was to automatically print enum values as integers).
This enum will need a formatter overload if we ever want to print out its value in a logging statement. The main Cascade branch doesn't currently do that, but the cascade_chain branch does (to debug member selection policies in the SignatureStore subgroup), so I know it will be needed. It seems better to fix it in the main branch and then inherit the changes in cascade_chain than to fix it in cascade_chain and later backport the changes to the main branch.
This is unrelated to the logger changes in this branch, but it needs to be fixed to get the "build check" to pass on GitHub. GitHub recently updated their build servers to a later version of Ubuntu, which does not have a "python3.10" package - it has one named "python3.12" instead. The better way to ensure the latest python is installed in these build scripts is to install the "python3" package, which always points to the current Python 3 package in Ubuntu.
Apparently, GitHub's Ubuntu image used to include this package by default, but now it doesn't so we need to install it from apt. Again, this is unrelated to my spdlog changes, but needs to be committed to test if the changes will build on GitHub.
…update Update log usage to be compatible with spdlog 1.15 (Didn't notice earlier that "approved" wasn't the same as "merged")
Contributor
|
This doesn't look like finished code (there are still debugging print statements in the ServiceClient methods), but it also doesn't look like you are requesting to merge into the main branch of Cascade. Assuming the "oob" branch is a development branch for the OOB methods, I think it's fine to merge this and keep working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.