Skip to content

Base model#29

Open
Derovi wants to merge 6 commits into
masterfrom
base_model
Open

Base model#29
Derovi wants to merge 6 commits into
masterfrom
base_model

Conversation

@Derovi

@Derovi Derovi commented Nov 23, 2020

Copy link
Copy Markdown
Owner

No description provided.

Comment on lines +2 to +6

/**
* @author derovi
*/

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-generated

Comment on lines +18 to +23
@Id
@GeneratedValue(generator = "UUID")
@GenericGenerator(name = "UUID",
strategy = "org.hibernate.id.UUIDGenerator")
private UUID id;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decks can be created localy. -> So when they did, Frontend created UUID for the deck. So u do not need to Generate UUID on the server again.

Comment on lines +44 to +46
@OneToMany(fetch = FetchType.LAZY)
private List<DeleteRecord> deleteRecords;
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to use it?

import java.util.UUID;

/**
* @author derovi

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shell I do the same?

Comment on lines +18 to +19
public class CardSimple extends AbstractCard {
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

card position ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u need to create a layout class, that contain cards positions for Grid Mode

Comment on lines +19 to +21
public enum AnswerType {
INTEGER, FLOAT, STRING
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you split the answer by type? I think it is ok, just to keep the answer only in a string,
Seems to me as an unnecessary complication

Comment on lines +16 to +18
public class CardExtended extends AbstractCard {
private String answer;
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sooooo
i think "CARD WITH ANSWER" is no exists, it is better to create a "ROTATED CARD". (we need to discuss it )

Comment on lines +29 to +32
@Id
@GeneratedValue(generator = "UUID")
@GenericGenerator(name = "UUID",
strategy = "org.hibernate.id.UUIDGenerator")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uuid also for card dsnt generated, Frontend do it by it own

@watislaf

Copy link
Copy Markdown
Collaborator
  1. I did the whole update of the deck and cards, as simple as creating a new one (without requests like create new, delete it, change position of)

  2. the types of cards we have with you are also different, it seems to me that there is no need to do the Type of answer, since it will be clear from the Question which answer.

  3. I have a regular card
    With a turn
    With answer input
    By you
    Regular card
    With the answer
    With the input of the answer.
    It seems to me that you want to make a card "With an answer" like pressed and flew the answer, and I want to do "pressed and she turned."
    The difference is that your answer input must have an Answer, and my answer is both answer and input. This needs to be discussed

  4. what are we going to do with the card positions? still hasn't been agreed. I remember you said to make a different kind of deck, where the cards fly out. This is normal. But even they have a positional parameter. Let's call you and think about which data will be Metadata and which will not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants