Skip to content

Update secrets and branding for one-click#62

Merged
HappyPaul55 merged 2 commits intomasterfrom
fix-secrets-for-one-click
Mar 21, 2025
Merged

Update secrets and branding for one-click#62
HappyPaul55 merged 2 commits intomasterfrom
fix-secrets-for-one-click

Conversation

@HappyPaul55
Copy link
Contributor

No description provided.

@HappyPaul55 HappyPaul55 requested a review from a team as a code owner March 21, 2025 10:31
@HappyPaul55 HappyPaul55 requested review from Copilot and removed request for a team March 21, 2025 10:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the secrets and branding for one-click by renaming a configuration property and updating related login logic.

  • Renames the required field "use_deskpro_saas" to an optional "use_advanced_connect" in the settings type.
  • Updates the login page to use the new field for determining the connection mode.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/types.ts Updated configuration property from required to optional to support advanced connect mode.
src/pages/LogIn.tsx Adjusted the login check and mode selection to use the new configuration field.
Files not reviewed (1)
  • manifest.json: Language not supported
Comments suppressed due to low confidence (2)

src/types.ts:14

  • Changing 'use_deskpro_saas' from a required field to an optional 'use_advanced_connect' could introduce unexpected behavior if the optional value is not handled elsewhere. Consider ensuring a default value is provided or that all consumers of this field properly handle its undefined state.
use_advanced_connect?: boolean,

src/pages/LogIn.tsx:35

  • The condition now checks for the existence of the entire settings object rather than specifically verifying if the new 'use_advanced_connect' field is defined. If 'use_advanced_connect' remains undefined, the login mode will default to 'local', which may not be the intended behavior.
if (context?.settings === undefined) {

@github-actions
Copy link

github-actions bot commented Mar 21, 2025

@HappyPaul55 HappyPaul55 merged commit 66a9722 into master Mar 21, 2025
4 checks passed
@HappyPaul55 HappyPaul55 deleted the fix-secrets-for-one-click branch March 21, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants