Update secrets and branding for one-click#62
Merged
HappyPaul55 merged 2 commits intomasterfrom Mar 21, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the secrets and branding for one-click by renaming a configuration property and updating related login logic.
- Renames the required field "use_deskpro_saas" to an optional "use_advanced_connect" in the settings type.
- Updates the login page to use the new field for determining the connection mode.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/types.ts | Updated configuration property from required to optional to support advanced connect mode. |
| src/pages/LogIn.tsx | Adjusted the login check and mode selection to use the new configuration field. |
Files not reviewed (1)
- manifest.json: Language not supported
Comments suppressed due to low confidence (2)
src/types.ts:14
- Changing 'use_deskpro_saas' from a required field to an optional 'use_advanced_connect' could introduce unexpected behavior if the optional value is not handled elsewhere. Consider ensuring a default value is provided or that all consumers of this field properly handle its undefined state.
use_advanced_connect?: boolean,
src/pages/LogIn.tsx:35
- The condition now checks for the existence of the entire settings object rather than specifically verifying if the new 'use_advanced_connect' field is defined. If 'use_advanced_connect' remains undefined, the login mode will default to 'local', which may not be the intended behavior.
if (context?.settings === undefined) {
|
Build for commit 140992d deployed to: https://github-pr-62.ci.next.deskprodemo.com URLs: |
AFOJ
reviewed
Mar 21, 2025
AFOJ
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.