Skip to content

fixup: use filesets#328

Merged
cole-h merged 3 commits into
mainfrom
fixup-use-filesets
Jun 18, 2026
Merged

fixup: use filesets#328
cole-h merged 3 commits into
mainfrom
fixup-use-filesets

Conversation

@cole-h

@cole-h cole-h commented Jun 18, 2026

Copy link
Copy Markdown
Member

Prevent rebuilds when the code didn't change.

Summary by CodeRabbit

  • Chores
    • Improved build system configuration with more explicit and maintainable package construction methods.

Prevent rebuilds when the code didn't change.
@cole-h cole-h enabled auto-merge June 18, 2026 18:46
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • dist/index.js is excluded by !**/dist/**
  • flake.lock is excluded by !**/*.lock
  • package-lock.json is excluded by !**/package-lock.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 24799ce8-9465-4de0-8fe6-7c788e00d2fd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

flake.nix replaces the craneLib.path-based source derivation (which filtered inputs.self by exclusion) with lib.fileset.toSource using an explicit inclusion set of Cargo manifests, .cargo, and src/. A local lib = pkgs.lib binding is introduced and used consistently for lib.optionals and lib.optionalString throughout sharedAttrs.

Changes

flake.nix sharedAttrs refactor

Layer / File(s) Summary
sharedAttrs source derivation and lib binding
flake.nix
Introduces lib = pkgs.lib local binding, replaces craneLib.path exclusion-filter approach with lib.fileset.toSource built from an explicit union of Cargo manifests, .cargo, and src/, and updates buildInputs and postFixup stanzas to use lib.optionals/lib.optionalString via the local alias.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐇 Hoppity hop through the Nix flake land,
Old exclusion filters swept away by paw,
fileset.toSource takes a cleaner stand —
only Cargo, .cargo, and src/ in its maw.
lib now local, consistent, and grand,
the rabbit nods: this is tidy. Hurrah!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fixup: use filesets' directly corresponds to the main change: migrating from craneLib.path to fileset.toSource for more precise dependency tracking and preventing unnecessary rebuilds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixup-use-filesets

Comment @coderabbitai help to get the list of available commands and usage tips.

@cole-h cole-h requested a review from lucperkins June 18, 2026 20:06
@cole-h cole-h added this pull request to the merge queue Jun 18, 2026
Merged via the queue into main with commit 0e801cf Jun 18, 2026
11 checks passed
@cole-h cole-h deleted the fixup-use-filesets branch June 18, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants