Feature/analytics intelligence engine#133
Open
Ritesh2332 wants to merge 9 commits into
Open
Conversation
Harxhit
added
the
gssoc:approved
- Remove EngagementEvent model, enum, and migration; reuse CardView - Rewrite trackEvent() to create cardView rows with hashed viewerIp - Revert docker-compose Postgres port to 5432:5432 - Remove package-lock.json (project uses pnpm) - Resolve schema conflict with upstream Event/EventAttendee models Co-authored-by: Cursor <cursoragent@cursor.com>
ShantKhatri
added
the
critical
Contributor
|
@Harxhit , there are schema changes here, could you please review this? |
Harxhit
reviewed
May 20, 2026
Collaborator
There was a problem hiding this comment.
Please revert this as we do not need it.
Harxhit
reviewed
May 20, 2026
Harxhit
reviewed
May 20, 2026
| userId String @map("user_id") | ||
| viewerId String? @map("viewer_id") | ||
|
|
||
| cardId String? @map("card_id") |
Harxhit
reviewed
May 20, 2026
| id String @id @default(uuid()) | ||
|
|
||
| userId String @map("user_id") | ||
| viewerId String? @map("viewer_id") |
Harxhit
reviewed
May 20, 2026
| cardId String? @map("card_id") // null = default profile view | ||
| ownerId String @map("owner_id") // card/profile owner | ||
| viewerId String? @map("viewer_id") // null = anonymous web viewer | ||
| viewerIp String? @map("viewer_ip") |
Collaborator
There was a problem hiding this comment.
Need to hash the IP here.
Harxhit
reviewed
May 20, 2026
| @@ -30,18 +30,20 @@ model User { | |||
| viewedCards CardView[] @relation("cardViewer") | |||
| followLogs FollowLog[] | |||
Collaborator
There was a problem hiding this comment.
FollowLog model creation is missing.
Harxhit
reviewed
May 20, 2026
| LINK_CLICK | ||
| FOLLOW_ATTEMPT | ||
| FOLLOW_SUCCESS | ||
| QR_SCAN |
Harxhit
reviewed
May 20, 2026
|
|
||
| eventType: 'PROFILE_VIEW', | ||
|
|
||
| source: (request.query as any)?.source || 'link', |
Collaborator
There was a problem hiding this comment.
Could we not use any here breaks the type safety.
Harxhit
reviewed
May 20, 2026
Collaborator
There was a problem hiding this comment.
Revert changes in this file.
Harxhit
reviewed
May 20, 2026
Collaborator
There was a problem hiding this comment.
CardView and EngagementEvent are doing the same job
Collaborator
|
@Ritesh2332 Please add the issues this PR closes so I can get better context and understand whether it also includes the API layer. Also fix the merge conflicts. |
Author
|
Addressed the requested review feedback:
Ready for re-review. |
ShantKhatri
approved these changes
May 28, 2026
Contributor
|
@Ritesh2332 Please fix merge conflicts. |
Resolve conflicts in schema, auth, and public routes while keeping analytics trackEvent and upstream team/OAuth improvements. Co-authored-by: Cursor <cursoragent@cursor.com>
ShantKhatri
requested changes
Jun 6, 2026
| - devcard-pgdata:/var/lib/postgresql/data | ||
| healthcheck: | ||
| test: ['CMD-SHELL', 'pg_isready -U devcard'] | ||
| test: [ 'CMD-SHELL', 'pg_isready -U devcard' ] |
Contributor
There was a problem hiding this comment.
Nothing changed here, so please remove the blank space changes.
|
@Ritesh2332 is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
CI — Checks FailedBackend — FAIL
Mobile — SKIP
Web — SKIP
Last updated: |
Resolve auth, public routes, and schema conflicts; keep trackEvent analytics with upstream service layer. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves analytics tracking for public profile and card views by enhancing the existing
CardViewsystem instead of introducing a separate analytics schema.The implementation adds reusable tracking utilities, privacy-safe IP hashing, and cleaner route-level tracking while keeping the backend architecture lightweight and easier to maintain.
It also improves type safety in public analytics routes and lays the groundwork for future analytics and engagement insights.
Closes #28
What Changed
CardViewinfrastructure for analytics trackingmainHow to Test
CardViewentries are created in PostgreSQL.