refactor: use reusable ProfileLink component on home screen#204
Closed
Saurav09s wants to merge 8 commits into
Closed
refactor: use reusable ProfileLink component on home screen#204Saurav09s wants to merge 8 commits into
Saurav09s wants to merge 8 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the mobile HomeScreen to render platform/profile links using a new reusable ProfileLink component, aiming to replace the previously hardcoded platform badge UI.
Changes:
- Added a new
ProfileLinkcomponent for displaying a platform + username row with an “Open” affordance. - Updated
HomeScreento render up to 4 links viaProfileLinkand show a “+N” overflow indicator. - Reorganized the HomeScreen layout around the links/QR/actions sections.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| apps/mobile/src/screens/HomeScreen.tsx | Switches platform link rendering to ProfileLink and rearranges sections, but currently introduces JSX syntax issues. |
| apps/mobile/src/components/ProfileLink.tsx | Introduces the reusable link row component used by HomeScreen. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+144
to
+150
| <ProfileLink | ||
| key={link.id} | ||
| platform={platform?.name || link.platform} | ||
| username={link.username} | ||
| url={link.url} | ||
| onPress={() => Linking.openURL(link.url)} | ||
| /> |
Comment on lines
18
to
23
| import { APP_URL, API_BASE_URL } from '../config'; | ||
| import type { NativeStackNavigationProp } from '@react-navigation/native-stack'; | ||
| import type { RootStackParamList } from '../navigation/MainTabs'; | ||
| import ProfileLink from '../components/ProfileLink'; | ||
| import { Linking } from 'react-native'; | ||
|
|
Comment on lines
+309
to
+311
| marginTop: SPACING.md, | ||
| gap: SPACING.sm, | ||
| }, |
Comment on lines
+46
to
+69
| const styles = StyleSheet.create({ | ||
| card: { | ||
| flexDirection: 'row', | ||
| alignItems: 'center', | ||
| justifyContent: 'space-between', | ||
| padding: 16, | ||
| borderRadius: 12, | ||
| backgroundColor: '#161616', | ||
| marginBottom: 12, | ||
| }, | ||
| platform: { | ||
| fontSize: 16, | ||
| fontWeight: '600', | ||
| color: '#ffffff', | ||
| }, | ||
| username: { | ||
| marginTop: 4, | ||
| fontSize: 14, | ||
| color: '#a1a1aa', | ||
| }, | ||
| link: { | ||
| fontSize: 14, | ||
| fontWeight: '600', | ||
| color: '#4f8cff', |
| padding: 16, | ||
| borderRadius: 12, | ||
| backgroundColor: '#161616', | ||
| marginBottom: 12, |
Comment on lines
+12
to
+18
| type ProfileLinkProps = { | ||
| platform: string; | ||
| username: string; | ||
| url: string; | ||
| onPress?: () => void; | ||
| }; | ||
|
|
Comment on lines
+19
to
+42
| export default function ProfileLink({ | ||
| platform, | ||
| username, | ||
| url, | ||
| onPress, | ||
| }: ProfileLinkProps) { | ||
| const handlePress = () => { | ||
| if (onPress) { | ||
| onPress(); | ||
| return; | ||
| } | ||
|
|
||
| Linking.openURL(url); | ||
| }; | ||
|
|
||
| return ( | ||
| <Pressable style={styles.card} onPress={handlePress}> | ||
| <View> | ||
| <Text style={styles.platform}>{platform}</Text> | ||
| <Text style={styles.username}>{username}</Text> | ||
| </View> | ||
|
|
||
| <Text style={styles.link}>Open</Text> | ||
| </Pressable> |
Harxhit
added
the
gssoc:approved
Signed-off-by: Saurav Suman <134825390+Saurav09s@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
Comments suppressed due to low confidence (1)
apps/mobile/src/screens/HomeScreen.tsx:47
searchUsername/setSearchUsernameis now unused (the search UI block was removed), which will trigger the RN ESLintno-unused-varsrule and fail lint/typecheck. Either restore the search UI or remove this state (and any related imports).
const [showQR, setShowQR] = useState(false);
const [refreshing, setRefreshing] = useState(false);
const [searchUsername, setSearchUsername] = useState('');
const profileUrl = user?.defaultCardId
? `${APP_URL}/devcard/${user.defaultCardId}`
: `${APP_URL}/u/${user?.username}`;
Comment on lines
+184
to
+190
| </TouchableOpacity> | ||
|
|
||
| {/* QR Code Section */} | ||
| {/* Action Buttons */} | ||
| <View style={styles.actions}> | ||
| <TouchableOpacity | ||
| style={styles.qrSection} | ||
| onPress={() => setShowQR(!showQR)} | ||
| style={styles.actionButton} | ||
| onPress={handleShare} |
Comment on lines
+310
to
+312
| marginTop: SPACING.md, | ||
| gap: SPACING.sm, | ||
| }, |
| </SafeAreaView> | ||
| </View> | ||
| </ScrollView> | ||
| </SafeAreaView > |
Comment on lines
+12
to
+25
| type ProfileLinkProps = { | ||
| platform: string; | ||
| username: string; | ||
| url: string; | ||
| onPress?: () => void; | ||
| }; | ||
| import { | ||
| COLORS, | ||
| SPACING, | ||
| FONT_SIZE, | ||
| BORDER_RADIUS, | ||
| } from '../theme/tokens'; | ||
| export default function ProfileLink({ | ||
| platform, |
Comment on lines
+30
to
+36
| const handlePress = () => { | ||
| if (onPress) { | ||
| onPress(); | ||
| return; | ||
| } | ||
|
|
||
| Linking.openURL(url); |
| padding: SPACING.md, | ||
| borderRadius: BORDER_RADIUS.md, | ||
| backgroundColor: COLORS.bgCard, | ||
| marginBottom: SPACING.sm, |
Comment on lines
+19
to
+23
| import { APP_URL, API_BASE_URL } from '../config'; | ||
| import type { NativeStackNavigationProp } from '@react-navigation/native-stack'; | ||
| import type { RootStackParamList } from '../navigation/MainTabs'; | ||
| import ProfileLink from '../components/ProfileLink'; | ||
|
|
Contributor
|
@Saurav09s There are some reviews from co-pilote, could you please look into this? |
Author
|
@ShantKhatri can you please tell me about 1st review "The “View a DevCard” search/lookup section appears to have been removed as part of this refactor, but the PR description only mentions swapping platform badges for ProfileLink. If this feature removal is intentional, update the PR description; otherwise, please restore the search section." I think I didn't remove it. Rest all I would fix and again push |
Signed-off-by: Saurav Suman <134825390+Saurav09s@users.noreply.github.com>
Comment on lines
329
to
333
| linksContainer: { | ||
| marginTop: SPACING.md, | ||
| gap: SPACING.sm, | ||
| }, | ||
| loadingRoot: { |
Comment on lines
+160
to
174
| {/* Platform Links */} | ||
| <View style={styles.linksContainer}> | ||
| {links.slice(0, 4).map(link => { | ||
| const platform = PLATFORMS[link.platform]; | ||
|
|
||
| return ( | ||
| <ProfileLink | ||
| key={link.id} | ||
| platform={platform?.name || link.platform} | ||
| username={link.username} | ||
| url={link.url} | ||
| /> | ||
| ); | ||
| })} | ||
| </View> |
Comment on lines
+233
to
+251
| {/* Stats */} | ||
| <View style={styles.stats}> | ||
| <View style={styles.statItem}> | ||
| <Text style={styles.statNumber}>{links.length}</Text> | ||
| <Text style={styles.statLabel}>Links</Text> | ||
| </View> | ||
|
|
||
| {/* Search / Lookup */} | ||
| <View style={styles.searchSection}> | ||
| <Text style={styles.searchLabel}>🔍 View a DevCard</Text> | ||
| <View style={styles.searchRow}> | ||
| <TextInput | ||
| style={styles.searchInput} | ||
| placeholder="Enter username..." | ||
| placeholderTextColor={COLORS.textMuted} | ||
| value={searchUsername} | ||
| onChangeText={setSearchUsername} | ||
| autoCapitalize="none" | ||
| autoCorrect={false} | ||
| returnKeyType="go" | ||
| onSubmitEditing={() => { | ||
| const u = searchUsername.trim(); | ||
| if (u) (navigation as any).navigate('DevCardView', { username: u }); | ||
| }} | ||
| /> | ||
| <TouchableOpacity | ||
| style={styles.searchBtn} | ||
| onPress={() => { | ||
| const u = searchUsername.trim(); | ||
| if (u) (navigation as any).navigate('DevCardView', { username: u }); | ||
| }} | ||
| > | ||
| <Text style={styles.searchBtnText}>Go →</Text> | ||
| </TouchableOpacity> | ||
| </View> | ||
| <View style={styles.statDivider} /> | ||
| <View style={styles.statItem}> | ||
| <Text style={styles.statNumber}>{analytics?.totalViews || 0}</Text> | ||
| <Text style={styles.statLabel}>Views</Text> | ||
| </View> | ||
|
|
||
| {/* Stats */} | ||
| <View style={styles.stats}> | ||
| <View style={styles.statItem}> | ||
| <Text style={styles.statNumber}>{links.length}</Text> | ||
| <Text style={styles.statLabel}>Links</Text> | ||
| </View> | ||
| <View style={styles.statDivider} /> | ||
| <View style={styles.statItem}> | ||
| <Text style={styles.statNumber}>{analytics?.totalViews || 0}</Text> | ||
| <Text style={styles.statLabel}>Views</Text> | ||
| </View> | ||
| <View style={styles.statDivider} /> | ||
| <View style={styles.statItem}> | ||
| <Text style={styles.statNumber}>{analytics?.followsCount || 0}</Text> | ||
| <Text style={styles.statLabel}>Follows</Text> | ||
| </View> | ||
| <View style={styles.statDivider} /> | ||
| <View style={styles.statItem}> | ||
| <Text style={styles.statNumber}>{analytics?.followsCount || 0}</Text> | ||
| <Text style={styles.statLabel}>Follows</Text> | ||
| </View> | ||
| </ScrollView> | ||
| </SafeAreaView> | ||
| </View> | ||
| </ScrollView> | ||
| </SafeAreaView > |
Comment on lines
+30
to
+41
| const handlePress = async () => { | ||
| if (onPress) { | ||
| onPress(); | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| await Linking.openURL(url); | ||
| } catch (error) { | ||
| console.warn('Failed to open profile link:', error); | ||
| } | ||
| }; |
Comment on lines
+36
to
+41
| try { | ||
| await Linking.openURL(url); | ||
| } catch (error) { | ||
| console.warn('Failed to open profile link:', error); | ||
| } | ||
| }; |
Comment on lines
+24
to
+51
| export default function ProfileLink({ | ||
| platform, | ||
| username, | ||
| url, | ||
| onPress, | ||
| }: ProfileLinkProps) { | ||
| const handlePress = async () => { | ||
| if (onPress) { | ||
| onPress(); | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| await Linking.openURL(url); | ||
| } catch (error) { | ||
| console.warn('Failed to open profile link:', error); | ||
| } | ||
| }; | ||
|
|
||
| return ( | ||
| <Pressable style={styles.card} onPress={handlePress}> | ||
| <View> | ||
| <Text style={styles.platform}>{platform}</Text> | ||
| <Text style={styles.username}>{username}</Text> | ||
| </View> | ||
|
|
||
| <Text style={styles.link}>Open</Text> | ||
| </Pressable> |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
Comments suppressed due to low confidence (1)
apps/mobile/src/screens/HomeScreen.tsx:57
fetchDatausestokenfor Authorization but the initialuseEffecthas an empty dependency array andfetchDatadoesn’t guard againsttokenbeing null. Iftokenis set after the first render (e.g., after login), HomeScreen won’t refetch and may send requests withBearer null. Consider returning early when!tokenand rerunning the effect whentokenchanges (or memoizingfetchDatawith[token]and depending on it).
useEffect(() => {
fetchData();
}, []);
const fetchData = async () => {
try {
const [profileRes, analyticsRes] = await Promise.all([
fetch(`${API_BASE_URL}/api/profiles/me`, {
headers: { Authorization: `Bearer ${token}` },
}),
fetch(`${API_BASE_URL}/api/analytics/overview`, {
headers: { Authorization: `Bearer ${token}` },
})
Comment on lines
34
to
40
| export default function HomeScreen({ navigation }: Props) { | ||
| const { user, token } = useAuth(); | ||
| const [links, setLinks] = useState<PlatformLink[]>([]); | ||
| const [analytics, setAnalytics] = useState<any>(null); | ||
| const [showQR, setShowQR] = useState(false); | ||
| const [refreshing, setRefreshing] = useState(false); | ||
| const [loading, setLoading] = useState(true); | ||
| const [searchUsername, setSearchUsername] = useState(''); | ||
|
|
Comment on lines
+138
to
151
| <View style={styles.linksContainer}> | ||
| {links.slice(0, 4).map(link => { | ||
| const platform = PLATFORMS[link.platform]; | ||
|
|
||
| return ( | ||
| <ProfileLink | ||
| key={link.id} | ||
| platform={platform?.name || link.platform} | ||
| username={link.username} | ||
| url={link.url} | ||
| /> | ||
| ); | ||
| })} | ||
| </View> |
Comment on lines
203
to
213
| <TouchableOpacity | ||
| style={styles.actionButton} | ||
| onPress={() => (navigation as any).navigate('DevCardView', { username: user?.username || '' })} | ||
| activeOpacity={0.85}> | ||
| <Text style={styles.actionEmoji}>👁️</Text> | ||
| <Text style={styles.actionText}>Preview</Text> | ||
| </TouchableOpacity> | ||
| </View> | ||
|
|
||
| {/* Search / Lookup */} | ||
| <View style={styles.searchSection}> | ||
| <Text style={styles.searchLabel}>🔍 View a DevCard</Text> | ||
| <View style={styles.searchRow}> | ||
| <TextInput | ||
| style={styles.searchInput} | ||
| placeholder="Enter username..." | ||
| placeholderTextColor={COLORS.textMuted} | ||
| value={searchUsername} | ||
| onChangeText={setSearchUsername} | ||
| autoCapitalize="none" | ||
| autoCorrect={false} | ||
| returnKeyType="go" | ||
| onSubmitEditing={() => { | ||
| const u = searchUsername.trim(); | ||
| if (u) (navigation as any).navigate('DevCardView', { username: u }); | ||
| }} | ||
| /> | ||
| <TouchableOpacity | ||
| style={styles.searchBtn} | ||
| onPress={() => { | ||
| const u = searchUsername.trim(); | ||
| if (u) (navigation as any).navigate('DevCardView', { username: u }); | ||
| }} | ||
| > | ||
| <Text style={styles.searchBtnText}>Go →</Text> | ||
| </TouchableOpacity> | ||
| </View> | ||
| </View> | ||
|
|
||
| {/* Stats */} | ||
| <View style={styles.stats}> |
| @@ -156,29 +134,29 @@ | |||
| {user?.bio && <Text style={styles.bio}>{user.bio}</Text>} | |||
|
|
|||
| {/* Platform Links Summary */} | |||
Comment on lines
+309
to
+311
| marginTop: SPACING.md, | ||
| gap: SPACING.sm, | ||
| }, |
Comment on lines
+30
to
+40
| const handlePress = async () => { | ||
| if (onPress) { | ||
| onPress(); | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| await Linking.openURL(url); | ||
| } catch (error) { | ||
| console.warn('Failed to open profile link:', error); | ||
| } |
Comment on lines
+24
to
+52
| export default function ProfileLink({ | ||
| platform, | ||
| username, | ||
| url, | ||
| onPress, | ||
| }: ProfileLinkProps) { | ||
| const handlePress = async () => { | ||
| if (onPress) { | ||
| onPress(); | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| await Linking.openURL(url); | ||
| } catch (error) { | ||
| console.warn('Failed to open profile link:', error); | ||
| } | ||
| }; | ||
|
|
||
| return ( | ||
| <Pressable style={styles.card} onPress={handlePress}> | ||
| <View> | ||
| <Text style={styles.platform}>{platform}</Text> | ||
| <Text style={styles.username}>{username}</Text> | ||
| </View> | ||
|
|
||
| <Text style={styles.link}>Open</Text> | ||
| </Pressable> | ||
| ); |
Comment on lines
+142
to
+149
| return ( | ||
| <ProfileLink | ||
| key={link.id} | ||
| platform={platform?.name || link.platform} | ||
| username={link.username} | ||
| url={link.url} | ||
| /> | ||
| ); |
Comment on lines
+45
to
50
| useEffect(() => { | ||
| fetchData(); | ||
| }, []); | ||
|
|
||
| const fetchData = async () => { | ||
| try { |
ShantKhatri
approved these changes
May 28, 2026
Comment on lines
203
to
213
| <TouchableOpacity | ||
| style={styles.actionButton} | ||
| onPress={() => (navigation as any).navigate('DevCardView', { username: user?.username || '' })} | ||
| activeOpacity={0.85}> | ||
| <Text style={styles.actionEmoji}>👁️</Text> | ||
| <Text style={styles.actionText}>Preview</Text> | ||
| </TouchableOpacity> | ||
| </View> | ||
|
|
||
| {/* Search / Lookup */} | ||
| <View style={styles.searchSection}> | ||
| <Text style={styles.searchLabel}>🔍 View a DevCard</Text> | ||
| <View style={styles.searchRow}> | ||
| <TextInput | ||
| style={styles.searchInput} | ||
| placeholder="Enter username..." | ||
| placeholderTextColor={COLORS.textMuted} | ||
| value={searchUsername} | ||
| onChangeText={setSearchUsername} | ||
| autoCapitalize="none" | ||
| autoCorrect={false} | ||
| returnKeyType="go" | ||
| onSubmitEditing={() => { | ||
| const u = searchUsername.trim(); | ||
| if (u) (navigation as any).navigate('DevCardView', { username: u }); | ||
| }} | ||
| /> | ||
| <TouchableOpacity | ||
| style={styles.searchBtn} | ||
| onPress={() => { | ||
| const u = searchUsername.trim(); | ||
| if (u) (navigation as any).navigate('DevCardView', { username: u }); | ||
| }} | ||
| > | ||
| <Text style={styles.searchBtnText}>Go →</Text> | ||
| </TouchableOpacity> | ||
| </View> | ||
| </View> | ||
|
|
||
| {/* Stats */} | ||
| <View style={styles.stats}> |
Comment on lines
+309
to
+311
| marginTop: SPACING.md, | ||
| gap: SPACING.sm, | ||
| }, |
Comment on lines
+30
to
+40
| const handlePress = async () => { | ||
| if (onPress) { | ||
| onPress(); | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| await Linking.openURL(url); | ||
| } catch (error) { | ||
| console.warn('Failed to open profile link:', error); | ||
| } |
Contributor
|
No updates for the last few weeks, so closing this PR according to policy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored HomeScreen to use reusable ProfileLink component.
Changes
Testing