Skip to content

Clear the overrides-only filter when clearing all overrides #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duncan-daydream merged 1 commit into from
Jul 27, 2026
Merged

Clear the overrides-only filter when clearing all overrides #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/DevConfiguration/Editor/Config Variable List/ConfigVariableListViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ final class ConfigVariableListViewModel: ConfigVariableListViewModeling {

func confirmClearAllOverrides() {
document.removeAllOverrides()
showOverridesOnly = false
}


Expand Down
18 changes: 18 additions & 0 deletions ...rationTests/Unit Tests/Editor/Config Variable List/ConfigVariableListViewModelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,6 +767,24 @@ struct ConfigVariableListViewModelTests: RandomValueGenerating {
}


@Test
mutating func confirmClearAllOverridesClearsShowOverridesOnly() {
// set up with an override and the overrides-only filter engaged
let variable = randomRegisteredVariable(defaultContent: .string(randomAlphanumericString()))
let document = makeDocument(registeredVariables: [variable])
let viewModel = makeViewModel(document: document)

document.setOverride(.string(randomAlphanumericString()), forKey: variable.key)
viewModel.showOverridesOnly = true

// exercise
viewModel.confirmClearAllOverrides()

// expect the filter is turned back off
#expect(!viewModel.showOverridesOnly)
}


// MARK: - undo

@Test
Expand Down
Loading