Repository navigation
Warn when a config sets a key removed in 1.0 - #163
Merged
Merged
Conversation
…al path for the library
…s in the measurement script
…hold and learning.adaptiveThresholds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conscience.loadThresholdandlearning.adaptiveThresholdswere documented in 0.74.1 and removed since; no code reads them. A config file that still sets one loaded without a word, so a user could believe the setting still worked.Change
src/config.ts: a user file or a project file that sets either key now adds one config warning for that key. The warning names the key, says it was removed in 1.0 and is ignored, and says what happens now: no score loads a skill by itself (the conscience names a skill and asks the agent to load it;conscience.skills.modeis the only switch), and thresholds never change on their own (/warden recommendsuggests changes from hold history).minHoldsForAdaptive,adaptationRate) were never documented and give no warning.docs/configuration.md: a "Removed in 1.0" note.CHANGELOG.md: 0.90.0.Tests
Each key gives exactly one warning from the user file and one from a project file; a config without them gives none. The existing test for a file that sets the removed keys now expects the two warnings.
npm run checkpasses (1,413 tests).