Skip to content

Start clean when a rebuild converts to zero records #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sauerdaniel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Start clean when a rebuild converts to zero records #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,19 @@ function syncSharedSession(
...(modelId ? { model: modelId } : {}),
});
convertAndImportMessages(session, priorMessages, customToolNameToSdk);
// Nothing survived conversion. This happens when every prior message is one pi
// synthesises rather than one Claude Code can replay — a lone developer notice
// ahead of the first user turn is the common case, and an interactive session in
// a project that injects rules or an AGENTS.md notice starts exactly that way.
// save() then writes no file at all, so resuming this id fails the whole turn
// with "No conversation found with session ID". Starting clean is also the
// accurate description: there is no prior turn for Claude Code to resume.
if (session.messages.length === 0) {
debug(`rebuild produced 0 records from ${priorMessages.length} prior message(s); starting clean instead of resuming a session that was never written`);
debug(`syncResult: path=clean-start empty-rebuild`);
sharedSession = null;
return { sessionId: null };
}
session.save();
verifyWrittenSession(session.jsonlPath, session.sessionId, session.messages.length, cwd);
sharedSession = { sessionId: session.sessionId, cursor: priorMessages.length, cwd };
Expand Down