Repository navigation
fix: escape pipes and collapse newlines in markdown table cells - #30
Merged
DhanushNehru merged 1 commit intoNov 6, 2026
Merged
Conversation
URLs and stack evidence details went into the summary, accessibility and stack tables unescaped, so a single | in a page title or header value started a new column and broke the row (DevelopersGlobal#12). Write every value in those tables through cell(), which escapes | as \| and collapses newlines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
report.gowrites URLs and stack evidence details straight into the pipe-delimited markdown tables, so a single|in a page title, a URL query string or a header value starts a new column and breaks the row (#12).Root cause
WriteMarkdowninterpolated values into the summary, accessibility and stack tables without escaping. A literal|in any free-text value collides with the table delimiter, and a newline inside a value starts a new row.Fix
Add a
cell()helper that escapes|as\|and collapses\r\n/\n/\rto spaces, and write every string value in the three tables (summary, accessibility, stack) through it. Cells without pipes or newlines render exactly as before.Testing
report_test.go: a page whose URL and title carry|plus a stack finding whose evidence detail carries|and\r\nrenders one intact escaped row (\|), and every data row keeps its expected number of unescaped pipes; a plain page still renders the identical row.go test ./...all packages pass;go vetclean.