Repository navigation
Resolve relative links against <base href> when present - #31
Merged
DhanushNehru merged 1 commit intoNov 6, 2026
Conversation
jay23606
deleted the
pr-go/13-resolve-relative-links-against-base-href
branch
November 6, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
parseHTMLresolves relativehrefandsrcvalues against the page URL only. When a page declares a<base href>, links, stylesheets, scripts, forms and feeds resolve against the wrong base, which yields wrong routes and missed assets.Change
parseHTMLnow uses the first<base href>in the document, resolved against the page URL, as the base for that page. Pages without a<base>element with anhrefbehave exactly as before.Testing
TestParseHTMLBaseHref, which fails on the previous code (base href links [https://fixture.test/site/guide]) and passes with this change.go test -run "^TestParseHTMLBaseHref$" .passes.go test ./...passes.Regression test: fails on base twice (/base href links [/), passes on fix twice (
go test -run "^TestParseHTMLBaseHref$" .)Fixes #13