fix(deps): patch critical next RCE advisories (GHSA-p293/GHSA-2xp9), sharp and js-yaml - #213
Merged
Merged
Conversation
Raise next 16.3.0 -> 16.3.3 in apps/dokploy and add two version-scoped entries to the existing root pnpm.overrides block. - GHSA-p293-qw3h-jr36 (critical, CVSS 9.0) - RCE on Windows-hosted servers - GHSA-2xp9-vwfh-vxw4 (critical) - RCE in the Image Optimization API via AVIF - GHSA-rgj7-g3m4-5g8c (high) - sharp - GHSA-2883-w6h3-9f4x (high) - js-yaml Same-minor patch for next. sharp was resolving 0.35.3, one patch below the floor, and the next bump alone did not lift it, so it needs its own version-scoped override. The three existing overrides are untouched. pnpm audit --prod: 259 -> 248 findings, critical 11 -> 5; next, sharp and js-yaml all cleared. Resolved pair count is identical at 1826 and exactly one declared specifier changed, so nothing unrelated moved. Only the manifests and the lockfile are touched. No workflow file is modified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Advisories published after this fleet's last green dependency audit. This repo
was resolving
next16.3.0,sharp0.35.3 andjs-yaml4.1.1, all in the production tree.nextnextsharp<0.35.4, patched 0.35.4js-yamlNeither
nextadvisory needs authentication.What changed
apps/dokploy/package.json, the rootpackage.jsonandpnpm-lock.yamlonly. No workflow file is touched.apps/dokploy/package.jsonnext16.3.016.3.3package.jsonpnpm.overridessharp@<0.35.4to^0.35.4andjs-yaml@4to4.3.2next16.3.0 to 16.3.3 is a same-minor patch release, the smallest possible fix, and it stays on the 16 major.sharpstill needed an override here even on the 16.3 line. The tree was resolving 0.35.3, one patch below the floor, and thenextbump alone did not lift it. The override is version-scoped (sharp@<0.35.4) so it raises only copies below the floor.js-yamlis in the production tree, so it gets a version-scoped override (js-yaml@4) that keeps consumers inside their own major. A blanket override would drag any 3.x consumer onto 4.x, which removedsafeLoad/safeDump.esbuild,better-calland@better-fetch/fetchkeep their pinned values; the two new keys were added alongside them, not merged over them.name@versionpairs was compared betweenHEADand this branch. The total count is identical at 1826, the only differences arenextandsharp's platform binaries, and exactly one declared specifier changed.@tiptap/*does not appear in this repo.pnpm audit --prodproduction audit, before / afterBaseline captured on the unmodified tree at
295df490.Watched packages flagged before:
js-yaml,next,sharp.Watched packages flagged after: none.
The criticals that remain belong to unrelated advisories outside the scope of this sweep and are deliberately untouched.
Verified locally
pnpm install --lockfile-only(pnpm 10.22.0 via corepack, the repo's ownpackageManager)pnpm-lock.yamlnext16.3.3,sharp0.35.4,js-yaml4.3.2name@versionpairs, before to afternextandsharpbinaries differnext)git ls-files --eoli/lf w/lfThe build and typecheck were not run locally and are not claimed to pass. A full install of this monorepo is not reproducible on the machine this branch was prepared on. The repo has substantial CI (
pull-request.yml,format.yml,dokploy.yml,upgrade-integration-test.ymlamong eight workflows), which is the gate. Please do not merge on a red build.One thing deliberately left alone, and it is worth the owner's attention.
packages/server/src/emails/is a self-contained sub-project with its ownpnpm-lock.yaml, outside the pnpm workspace, and that lockfile resolvesnext14.1.4 transitively underreact-email@^6.6.5. It declares nonextof its own. Next 14 has no patched release at all for these advisories, so the only fix there is a major upgrade ofreact-emailor ofnext, which is a migration rather than a dependency bump. It is untouched here and flagged rather than silently skipped. The same pattern, a preview/dev email server dragging in its own vulnerablenext, was found in another repo earlier in this sweep.Merge policy for this repo
This repository is not Dokploy source-bound. The classifier reads every column of both
applications.csvandcomposes.csvand finds no unit binding a git source to it, so no push here can redeploy anything, and it is one of the names explicitly confirmed untracked by the classifier's own self-test. It does have CI, so this PR is being squash-merged once its checks are green, not before.