ci: gate per-package e2e jobs on changed paths and add missing job timeouts - #10
Merged
Merged
Conversation
…meouts Two changes, both CI-only. 1. A `changes` gate job in ci.yml. Each of the nine e2e jobs runs `turbo run e2e --filter=<one package>`, so a commit that touches an unrelated package still pays for the whole matrix. A single dorny/paths-filter@v4 job now classifies the changed files and each e2e job carries `needs: changes` plus an `if:` on its own output. Filter keys use underscores because `needs.changes.outputs.e2e-core` would parse as a subtraction. Skipping is safe here: main is unprotected, so a skipped job cannot block a pull request. e2e-core if: needs.changes.outputs.e2e_core == 'true' e2e-core-oidc if: needs.changes.outputs.e2e_core_oidc == 'true' e2e-core-tokenless if: needs.changes.outputs.e2e_core_tokenless == 'true' e2e-cypress if: needs.changes.outputs.e2e_cypress == 'true' e2e-playwright if: needs.changes.outputs.e2e_playwright == 'true' e2e-puppeteer if: needs.changes.outputs.e2e_puppeteer == 'true' e2e-storybook if: needs.changes.outputs.e2e_storybook == 'true' e2e-vitest if: needs.changes.outputs.e2e_vitest == 'true' e2e-webdriverio if: needs.changes.outputs.e2e_webdriverio == 'true' Every filter includes .github/workflows/ci.yml, so a change to the workflow itself still runs all nine. The gate job gets timeout-minutes: 5, matching the other jobs in this workflow, and pull-requests: read for the filter step. 2. timeout-minutes on the three jobs that had none. Every job in ci.yml already declared one. The rule is 3 x the observed p90 duration rounded up to the nearest 5 minutes; none of these three had a usable sample in 72 h of run history, so each takes its class default. pr.yml check-commits 30 class default (other) publish-sdk.yml publish 60 class default (release) release.yml release 30 class default (build) No concurrency edit was planned for this repository.
|
The latest updates on your projects. Learn more about Snapvisor notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes, both CI-only.
changesgate job in ci.yml. Each of the nine e2e jobs runsturbo run e2e --filter=<one package>, so a commit that touches an unrelatedpackage still pays for the whole matrix. A single dorny/paths-filter@v4 job now
classifies the changed files and each e2e job carries
needs: changesplus anif:on its own output. Filter keys use underscores becauseneeds.changes.outputs.e2e-corewould parse as a subtraction. Skipping is safehere: main is unprotected, so a skipped job cannot block a pull request.
e2e-core if: needs.changes.outputs.e2e_core == 'true'
e2e-core-oidc if: needs.changes.outputs.e2e_core_oidc == 'true'
e2e-core-tokenless if: needs.changes.outputs.e2e_core_tokenless == 'true'
e2e-cypress if: needs.changes.outputs.e2e_cypress == 'true'
e2e-playwright if: needs.changes.outputs.e2e_playwright == 'true'
e2e-puppeteer if: needs.changes.outputs.e2e_puppeteer == 'true'
e2e-storybook if: needs.changes.outputs.e2e_storybook == 'true'
e2e-vitest if: needs.changes.outputs.e2e_vitest == 'true'
e2e-webdriverio if: needs.changes.outputs.e2e_webdriverio == 'true'
Every filter includes .github/workflows/ci.yml, so a change to the workflow
itself still runs all nine. The gate job gets timeout-minutes: 5, matching the
other jobs in this workflow, and pull-requests: read for the filter step.
declared one. The rule is 3 x the observed p90 duration rounded up to the
nearest 5 minutes; none of these three had a usable sample in 72 h of run
history, so each takes its class default.
pr.yml check-commits 30 class default (other)
publish-sdk.yml publish 60 class default (release)
release.yml release 30 class default (build)
No concurrency edit was planned for this repository.
Part of the CI pool right-sizing programme; edits derived from 72 h of run history.