ci: enable core e2e jobs against snapvisor prod - #8
Merged
Merged
Conversation
# Conflicts: # packages/cli/e2e/whoami.test.ts
|
The latest updates on your projects. Learn more about Snapvisor notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the three disabled core e2e CI jobs (
e2e-core,e2e-core-oidc,e2e-core-tokenless) now that snapvisor prod has the seeded fixture build (devino/snapvisor-js-e2e argos-ci#101),USER_ACCESS_TOKEN, and the GitHub-Actions OIDC exchange.Fork-owned fixes discovered while getting the suite green locally against
https://api.snapvisor.io:parseBuildReferencenow acceptsapp.snapvisor.iobuild URLs (source bug — the CLI rejected its own product's URLs, breaking everybuild/review/commentcommand given a snapvisor URL). Extended the host regex + added a unit-test case.change/review/analyticse2e tests extended to accept snapvisor hosts alongside argos hosts.whoamie2e assertions corrected to the real/mecontract (Me.user.id+ account-scopedslug;formatMeprints anAccounts:line, no per-userSlug:). The prior assertions were against a flat shape and never ran (job wasif: false).ARGOS_BUILD_NUMBER: "101"to thee2e-corerun env.Local verification (Windows, vs prod): CLI e2e 55 passed / 1 skipped (tokenless, by design) / 1 failed (
deploy); core e2e upload cjs+mjs both pass (builds 129/130). Thedeployfailure is a presigned-PUT upload timeout that reproduces only with a Windows libuv teardown crash locally — deferred to the CI Linux runners per the network-artifact rule.🤖 Generated with Claude Code