chore(size): raise the @useupup/core budget to 420 KB, measured - #405
Merged
Merged
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@useupup/core's budget was 0.89 kB from its ceiling before #393 landed, so the next core change of any size was going to be the one that hit it. #393 is that change.Measured, not estimated
@useupup/core2464bb8(post-#400 promotion) — job 1031602593458702e77(master + #393) — job 103212277087#393 costs +3.35 kB of core: the three Drive listing params, a paginated
drives.listwalk, and the synthetic "Shared with me" folder id both list paths branch on. No dependency was added and nothing moved onto core's mandatory path — principle 6 is intact, this is plain code for a default-off option.420 KB, and why that number. It clears the measured 412.46 kB by 7.5 kB — about 1.8%. Deliberately small: enough that a routine fix does not re-block a promotion, little enough that the next raise is a decision somebody makes on purpose rather than a ceiling nobody is near. A larger jump would buy quiet at the price of the gate meaning anything.
This unblocks the dev→master promotion in #404, which is otherwise green (including
Cross-framework E2E).