chore: promote dev to master (3.3.3 — drive decline reporting) - #412
Merged
Merged
Conversation
…ot a blocked popup
…in every framework and forward it from every uploader
…ut a session, so the auth view cannot retry itself in a loop
…p and assert the sign-in prompt itself
…eporting fix(core,react): report a declined drive consent as a cancellation
…per-twin test(scripts): hold the drive-sandbox escaper copy to the core implementation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes dev (
acbe762a) to master. Included since the last promotion (#409):DriveAuthFallbackauto-triggers sign-in on mount so the tile click's activation is still live, but the OneDrive, Dropbox and Box uploaders rendered it WITHOUT forwardingerror, so its own|| errorguard could never fire: a decline re-mounted the view with a freshattemptedRef, retriedwindow.openwith no activation left, got null, and the plugin truthfully reported a blocked popup about a user who had blocked nothing. The error is now forwarded from every uploader in all six framework packages, the popup attempt leaves an error behind when it ends without a session, and the decline is localised through the existing catalogue rather than an English literal.escapeDriveQueryValue.The changeset declares
@useupup/core,@useupup/react,@useupup/vue,@useupup/svelte,@useupup/angularand@useupup/vanillaas patch — every package whose source changed. Merging this cuts 3.3.3.Note for whoever merges the Version Packages PR:
@useupup/serverhas failed npm OIDC withENEEDAUTHon both 3.3.1 and 3.3.2 (#406), so expect eight of nine again, and expect the tag/Release step to be skipped with them.