add metadata options to launch template creation#168
Closed
juser0719 wants to merge 0 commit into
Closed
Conversation
juser0719
requested review from
Chaaany,
GwonsooLee,
YoungJinJung,
asbubam and
jupitersong
as code owners
Chaaany
reviewed
May 23, 2025
| Monitoring: &ec2.LaunchTemplatesMonitoringRequest{Enabled: aws.Bool(detailedMonitoringEnabled)}, | ||
| MetadataOptions: &ec2.LaunchTemplateInstanceMetadataOptionsRequest{ | ||
| HttpTokens: aws.String("required"), | ||
| HttpPutResponseHopLimit: aws.Int64(1), |
Contributor
There was a problem hiding this comment.
Hop limit을 조정해야하는 경우도 있으니 변수로 할당 받되 명시 안하면 1로 지정하는건 어때요?
Contributor
Author
There was a problem hiding this comment.
HttpPutResponseHopLimit 의 경우 optional로 받아오도록 수정했습니다! 리뷰 부탁드립니다!
Contributor
|
test code도 만들어주세요 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enforces IMDSv2 (Instance Metadata Service Version 2) for all EC2 instances deployed via goployer by adding metadata options to the launch template configuration.
Changes:
MetadataOptionsfield toCreateNewLaunchTemplatefunction inpkg/aws/ec2.goHttpTokens: "required"to enforce IMDSv2 token-based authenticationHttpPutResponseHopLimit: 1for additional security hardeningHttpEndpoint: "enabled"to keep metadata service accessibleSecurity Benefits:
User facing changes
Before:
After: