Skip to content

⚡ Bolt: Memoize ConversationsSidebar sort and avoid Date allocations #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Dexploarer wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

⚡ Bolt: Memoize ConversationsSidebar sort and avoid Date allocations #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-06-03 - Memoizing ISO date sorting
**Learning:** In React list components, `Array.sort()` with `new Date()` allocations is incredibly expensive (~10x slower than string comparison) on re-renders. `useMemo` combined with `localeCompare` on ISO date strings prevents this bottleneck.
**Action:** Always memoize derived lists and prefer lexicographical string comparisons over `Date` parsing for ISO 8601 timestamps.
13 changes: 7 additions & 6 deletions apps/app/src/components/ConversationsSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Conversations sidebar component — left sidebar with conversation list.
*/

import { useEffect, useRef, useState } from "react";
import { useEffect, useMemo, useRef, useState } from "react";
import { useApp } from "../AppContext";

interface ConversationsSidebarProps {
Expand Down Expand Up @@ -54,11 +54,12 @@ export function ConversationsSidebar({
}
}, [editingId]);

const sortedConversations = [...conversations].sort((a, b) => {
const aTime = new Date(a.updatedAt).getTime();
const bTime = new Date(b.updatedAt).getTime();
return bTime - aTime;
});
// ⚡ Bolt: Memoize the sorting of conversations and use string comparison instead of allocating new Date objects to prevent expensive computation on every re-render.
const sortedConversations = useMemo(() => {
return [...conversations].sort((a, b) =>
b.updatedAt.localeCompare(a.updatedAt),
);
Comment on lines +59 to +61

@gemini-code-assist gemini-code-assist Bot Apr 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Although localeCompare is faster than new Date() parsing, simple string comparison operators (> and <) are even more efficient for ISO 8601 strings. localeCompare is a heavy operation that accounts for locale-specific collation rules, which are unnecessary for lexicographical timestamp sorting. Using primitive comparisons will provide the best performance for this 'Bolt' optimization.

Suggested change
return [...conversations].sort((a, b) =>
b.updatedAt.localeCompare(a.updatedAt),
);
return [...conversations].sort((a, b) =>
b.updatedAt > a.updatedAt ? 1 : b.updatedAt < a.updatedAt ? -1 : 0,
);

}, [conversations]);

Comment on lines +57 to 63

@codereviewbot-ai codereviewbot-ai Bot Apr 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sorting of conversations by updatedAt uses localeCompare on the string values, which is efficient for ISO 8601 date strings. However, this approach assumes that all updatedAt fields are valid and consistently formatted. If any updatedAt value is malformed or not in ISO format, the sort order may be incorrect or could introduce subtle bugs. Consider validating the format of updatedAt or providing a fallback to ensure robust sorting:

const sortedConversations = useMemo(() => {
  return [...conversations].sort((a, b) => {
    if (!a.updatedAt || !b.updatedAt) return 0;
    return b.updatedAt.localeCompare(a.updatedAt);
  });
}, [conversations]);

Alternatively, ensure upstream that all updatedAt values are valid ISO strings.

const handleDoubleClick = (conv: { id: string; title: string }) => {
setEditingId(conv.id);
Expand Down
Loading