Skip to content

🎨 Palette: Add ARIA label to delete conversation button #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Dexploarer wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

🎨 Palette: Add ARIA label to delete conversation button #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/app/src/components/ConversationsSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ export function ConversationsSidebar({
setConfirmDeleteId(conv.id);
}}
Comment on lines 221 to 222

@codereviewbot-ai codereviewbot-ai Bot Apr 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no guard to prevent opening a new delete confirmation dialog while a delete operation is already in progress (deletingId). This could lead to inconsistent UI state if the user clicks delete on multiple conversations rapidly.

Recommendation:
Add a check to prevent setting a new confirmation dialog if deletingId is not null:

if (!deletingId) setConfirmDeleteId(conv.id);

title="Delete conversation"
aria-label="Delete conversation"

@gemini-code-assist gemini-code-assist Bot Apr 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When providing an aria-label for buttons within a list, it is a best practice to include the specific item's context (e.g., the conversation title). This helps screen reader users distinguish between multiple 'Delete' buttons when navigating by controls.

Suggested change
aria-label="Delete conversation"
aria-label={`Delete conversation: ${conv.title}`}

>
×
</button>
Expand Down
Loading