Feat/input#188
Merged
Merged
Conversation
|
@nafsonig Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
ayshadogo
approved these changes
May 29, 2026
Contributor
ayshadogo
left a comment
There was a problem hiding this comment.
LGTM
Thank you for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Complete ✅
I've successfully implemented strict validation on campaign initialization. Here's what was done:
1. Added Error Types (types.rs)
Added a comprehensive
Errorenum with five descriptive error variants:InvalidGoalAmount- when goal_amount ≤ 0InvalidEndTime- when end_time ≤ current ledger timestampInvalidAssets- when accepted_assets is emptyInvalidMilestones- when milestones aren't sorted or other milestone issuesMilestoneMismatch- when last milestone.target_amount ≠ goal_amount2. Implemented
initialize()Function (lib.rs)The function enforces all acceptance criteria in sequence:
InvalidGoalAmountenv.ledger().timestamp()for comparisonInvalidAssets3. Helper Functions
validate_milestones()- Ensures milestones are properly sorted and the last equals goal_amountpanic_with_error()- Converts error types to descriptive panic messages usingenv.panic_with_error()Key Features:
Activestatus and 0 raised_amountThe implementation prevents invalid campaigns from being deployed and provides clear error messaging for all failure scenarios.
Made changes.
closes #173