fix: escape regex metacharacters in search to prevent ReDoSEscape search regex input#14
Open
AaravKashyap12 wants to merge 1 commit into
Open
Conversation
|
@AaravKashyap12 is attempting to deploy a commit to the dhanika2006-7071's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
What this PR does
Escapes user-supplied search input before using it as a MongoDB
$regexin bothroutes/products.jsandroutes/stores.js:Changes
server/routes/products.js$regexserver/routes/stores.js$regexVerification
Note
This fix escapes regex metacharacters to prevent regex injection and reduce ReDoS risk. Full-text search performance on large datasets would benefit from MongoDB text indexes or a dedicated search service, tracked separately.