fix: exclude cancelled orders from totalRevenue on Dashboard#5
Open
vinamra1102 wants to merge 1 commit into
Open
fix: exclude cancelled orders from totalRevenue on Dashboard#5vinamra1102 wants to merge 1 commit into
vinamra1102 wants to merge 1 commit into
Conversation
The totalRevenue calculation on the entrepreneur Dashboard was including cancelled orders, showing inflated earnings that don't reflect actual income. Changed the calculation to filter out cancelled orders before summing the totalAmount.
|
@vinamra1102 is attempting to deploy a commit to the dhanika2006-7071's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi @Dhanika-Bhat, just following up on this PR when you get a chance! The fix is ready only 1 file changed in Dashboard.jsx line 82, Happy to make any changes if needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Closes #4
Cancelled orders were being included in the totalRevenue calculation
on the entrepreneur Dashboard, showing incorrect inflated earnings.
Change made
client/src/pages/Dashboard.jsxline 82 — added.filter()toexclude orders with status
cancelledbefore summing revenue.Before / After
counted in revenue
Type