Use source system id for fetching existing specimen and media#11
Open
Use source system id for fetching existing specimen and media#11
Conversation
…sid-for-fetching # Conflicts: # src/main/java/eu/dissco/sourcesystemdatachecker/service/SourceSystemDataCheckerService.java # src/test/java/eu/dissco/sourcesystemdatachecker/service/SourceSystemDataCheckerServiceTest.java
southeo
changed the title
samleeflang
reviewed
Mar 5, 2026
samleeflang
left a comment
samleeflang
left a comment
There was a problem hiding this comment.
Happy this gave some improvements! Create a new testUtils attribute for the SOURCE_SYSTEM now the test looks a bit strange
| deleted timestamp with time zone, | ||
| data jsonb, | ||
| original_data jsonb, | ||
| col_id text, |
Collaborator
Author
There was a problem hiding this comment.
idk why but my ide keeps reformatting this in the pre-commit hook 🙃 disabled that functionality for this specific commit lol
|
|
||
| // When | ||
| var result = repository.getDigitalSpecimens(Set.of(PHYSICAL_ID_1)); | ||
| var result = repository.getDigitalSpecimens(Set.of(PHYSICAL_ID_1), Set.of(APP_PID)); |
There was a problem hiding this comment.
Why use APP_PID here. Maybe rename it to PID or just add a new one SOURCE_SYSTEM_PID
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should narrow the scope for the expensive fetch
A batch may be from multiple source systems, so we have to use a list of source system ids (but if the list size = 1, this is basically the same thing)