Repository navigation
fix: move image to Node 22 for eMudhra CA distrust - #960
Merged
Merged
Conversation
The keys of eight eMudhra intermediate CAs can be recovered from their public certificates (disclosed 2026-10-20). Every TLS client in the image (Node, yt-dlp and Apprise through certifi, curl, Deno) still trusted chains through them, and none of them checks Certificate Transparency, so an on-path attacker could impersonate YouTube, GitHub (yt-dlp self-update) or plex.tv. Node 20 is end of life and will not get the updated bundled roots, so the image moves to node:22-bookworm-slim (22.23.4 carries the fix; bookworm keeps Python 3.11 for the curl_cffi stage). The no-cache release build picks up the fixed Debian ca-certificates, certifi and Deno. CI and release workflows move to Node 22 to match.
Contributor
📊 Test Coverage ReportBackend Coverage
Frontend Coverage
Coverage Requirements
Coverage report generated for commit 489a7fc |
Storybook 10.0.0 through 10.6.1 is affected by a critical advisory (GHSA-f2ph-cmg5-wxc8, missing origin validation in the preview), which fails the client critical-level audit in CI. Storybook is a dev dependency and is not part of the image. The @storybook/* packages move with the core so their versions match. 10.6.3 is newer but still inside the 5-day min-release-age window.
BigFlubba
approved these changes
Oct 22, 2026
BigFlubba
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The private keys of eight eMudhra intermediate certificate authorities can be recovered from their public certificates (disclosure, 2026-10-20). Browsers were protected by Certificate Transparency, but the HTTPS clients inside the Youtarr image don't check it, and every one of them still trusted certificates issued under those authorities. Someone able to intercept a server's traffic could have impersonated YouTube, plex.tv, or GitHub, where yt-dlp gets its updates.
node:20-slimtonode:22-bookworm-slim. Node 20 reached end of life in April and won't get the corrected root list; Node 22.23.4 has it. Staying on bookworm keeps Python at 3.11, which the curl_cffi build stage needs.Testing
Each client in the image was run against the disclosure site's test hosts, which serve certificates from the compromised intermediates (one through the eMudhra root, one through the Sectigo cross-sign):
Node 22 support ends on 2027-04-30, so the move to Node 24 should come before then.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Upis7aQ8f9zmaGAZQs36NQ