Repository navigation
fix: keep downloaded videos when SponsorBlock is unavailable - #966
Merged
Merged
Conversation
dialmaster
requested changes
Oct 26, 2026
dialmaster
left a comment
dialmaster
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for picking this up!
I only see a few small issues -- see my review comments :)
Recognize WARNING lines before the final SponsorBlock ERROR, reproduce all three extractor retries in the executor tests, and cover an unrelated video failure that must not inherit a false HTTP 403 auto-retry. Clarify that the SponsorBlock count appears in the live completion message.
gauvainw
force-pushed
the
fix/sponsorblock-timeout
branch
from
October 26, 2026 16:38
97c7127 to
51cf95e
Compare
Contributor
Author
|
Thank for the review ! I love the project man that's really great |
dialmaster
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #965.
A SponsorBlock lookup timeout can currently mark a successfully downloaded video as failed and remove it from the download archive, so the next run downloads it again.
Treat the unprefixed SponsorBlock API error as a warning, keep successful videos in the archive, and report the number of affected videos in the download's live completion message. This count is not persisted in job notes or included in run summaries or notifications. Repeated error lines for the same video count once. The
Preprocessing:form and other video download failures still count as failures.SponsorBlock API 403 errors and their preceding
WARNING:retry lines no longer trigger YouTube cookie advice or cause an unrelated video's failure to be auto-retried as a 403. Genuine video download 403s are still detected.Tests cover stdout and stderr, exit codes 0 and 1, the three retry warnings emitted with
--extractor-retries 3, archive retention, notification success/failure totals, and mixed failure cases. The troubleshooting guide describes the resulting behavior and where the SponsorBlock count appears.Testing
dev(71fcf937), which includes the dependency fixes from fix(deps): patch body-parser and multer security issues #967. This PR does not change dependency manifests or lockfiles relative todev.The regression tests use simulated process output. No live YouTube download or SponsorBlock outage was exercised. Docker/Compose integration was verified for the original revision; it was not rerun for this review revision because this workstation has no container runtime.