Repository navigation
fix: don't fail videos over an empty subtitle - #971
Merged
Merged
Conversation
When YouTube sent back an empty subtitle file, Youtarr marked the video as failed even though it downloaded fine, then downloaded it again on every run. Now the video is kept and the job shows a subtitle warning instead. If the video file itself is missing, it still counts as failed and is tried again next run. Refs: #958
Contributor
📊 Test Coverage ReportBackend Coverage
Frontend Coverage
Coverage Requirements
Coverage report generated for commit 4066089 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When YouTube sent back an empty subtitle file, Youtarr marked the video as failed even though it downloaded fine, then downloaded it again on every run.
Now the video is kept and the job shows a subtitle warning instead. If the video file itself is missing, it still counts as failed and is tried again next run.
Refs: #958