Make MUL_NUM fail on overflow - #112
Open
dstelzer wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
It's been suggested that we switch to omult16.a, a more efficient algorithm that also detects overflow consistently (or does it?). |
…s overflow, allowing for fail
…into mul-overflow-fail
dstelzer
marked this pull request as ready for review
September 9, 2026 20:57
Contributor
Author
|
@sehugg Mind looking over the 6502 changes quickly to make sure I haven't messed something up? It passes all the test cases, so I'm generally satisfied. (Just ignore the changes to the .adoc file, that's a consequence of how the docs are versioned.) |
Contributor
Author
|
Turns out this algorithm fails on certain values. Unfortunate. Switching to a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.