Skip to content

ViSR: Overview cameras for tomography and spectroscopy - #247

Merged
tomkane-dls merged 6 commits into
mainfrom
overview-cams
Nov 9, 2026
Merged

tomkane-dls merged 6 commits into
mainfrom
overview-cams

Conversation

@tomkane-dls

@tomkane-dls tomkane-dls commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Intent

Create overview cameras from the two microscopes that can be seen when the control drawer is open. This will help ease alignment of each sample. The plots are now contained in cells so only a subset are seen when the drawer is closed (to maximise the visualisations when on second screens in ViSR.

Changes

  • move CamPva to its own file
  • use disconnected symbol if we cannot receive frames
  • add visr's two usb cameras to the gui, one for spectroscopy and one for tomography, to view the stages/samples live
  • only show these when controls drawer is expanded
  • add composite plot placeholder to spectroscopy

Closes issue #246


Spectroscopy

Screenshot from 2026-10-22 14-23-39 Screenshot from 2026-10-22 14-23-49

Tomography

Screenshot from 2026-10-22 14-24-00 Screenshot from 2026-10-22 14-24-08

@tomkane-dls
tomkane-dls marked this pull request as ready for review October 22, 2026 11:29
@tomkane-dls tomkane-dls changed the title ViSR: Overview cameras for tomogrpahy and spectroscopy ViSR: Overview cameras for tomography and spectroscopy Nov 2, 2026
@tomkane-dls
tomkane-dls requested a review from EmsArnold November 9, 2026 11:10

@EmsArnold EmsArnold left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Technically, there is coverage regression as more code has been added without tests, but given the lack of tests generally in the visr app, this is not a problem unique to these additions.

@tomkane-dls

Copy link
Copy Markdown
Contributor Author

Merged in changes from enz locum PR

Updated so that composite image follows the style of other plots without data (diagonal lines)

See Spectrosocpy now:

Screenshot from 2026-11-09 11-55-46 image

@tomkane-dls

Copy link
Copy Markdown
Contributor Author

Looks good to me!

Technically, there is coverage regression as more code has been added without tests, but given the lack of tests generally in the visr app, this is not a problem unique to these additions.

Yes i agree - in general i did not add tests to the visr app as there weren't any there to begin with, I will make an issue to start making tests once we are happy with these recent changes.

@tomkane-dls
tomkane-dls merged commit da75073 into main Nov 9, 2026
1 of 2 checks passed
@tomkane-dls
tomkane-dls deleted the overview-cams branch November 9, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants