Conversation
douglaswinter
force-pushed
the
dw/coverage_ci
branch
from
50de06c to
6ddd723
Compare
douglaswinter
requested review from
EmsArnold,
VictoriaBeilsten-Edmands and
noemifrisina
| pull_request: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
If I understand this correctly, it will only run on pull requests that target main?
Does it need to be run on all pull requests instead?
There was a problem hiding this comment.
I think this is correct, you don't need to run it for a PR into something other than main... at some point you'll want that in main and then it will trigger (as in for this PR itself)
There was a problem hiding this comment.
How long does it take to run? If not long, can just add to all PRs.
There was a problem hiding this comment.
But 1) why? you can do whatever you want in your branch, I'm only interested at the point of merging to main; and 2) we could do it for all PRs, but we'd need to change the script to make it meaningful, which currently runs coverage on your change and then checks out main specifically to get a baseline coverage.
3 participants
Runs coverage on PR, on main, and ensures there is no regression on a per-project basis.
Fixes #28