Remove Any type on _convert_type #437

Activity

1. stan-dot

   added this to the 1.0.0 milestone on May 16, 2024
2. stan-dot

   added

   python

   on Sep 9, 2024
3. stan-dot commented on Sep 9, 2024

   

   stan-dot

   on Sep 9, 2024

   Contributor

   More actions

   @callumforrester have we moved away from mypy to pyright enough that we can remove | Any without waiting for that mypy issue?

   At the moment it does seem that we use mypy in the project
4. callumforrester commented on Sep 11, 2024

   

   callumforrester

   on Sep 11, 2024

   Contributor

   More actions

   Pending #619
5. callumforrester

   removed this from the 1.0.0 milestone on Mar 21, 2025
6. abbiemery

   added

   needs confirmationDoes this bug still exist?Does this bug still exist?

   c: cliRelates to CLI codeRelates to CLI code

   and removed

   python

   on Feb 25, 2026
7. abbiemery commented on Feb 27, 2026

   

   abbiemery

   on Feb 27, 2026

   Contributor

   More actions

   I don't think this is possible with pythons type system. Where there are cases of unions being passed into _convert_type removing the Any will fail as UnionType is not a type. We can remove the type and just have it as:

   def _convert_type(self, typ: Any, no_default: bool = True) -> type:
   
   

   If we want to clean it up a bit and be explicit about what we are doing (as the Any just flags to disregard any types anyway). Otherwise we can just ignore it.

   (@tpoliaw for a sanity check?)
8. abbiemery

   linked a pull request that will close this issuechore: Remove redundant type #1421on Feb 27, 2026
9. tpoliaw commented on Mar 3, 2026

   

   tpoliaw

   on Mar 3, 2026

   Contributor

   More actions

   The first line of the method is if typ is NoneType so it can't just be type. I remember unions being a pain so so if we're dealing with the Any case anyway, leaving it just as Any makes sense.
10. abbiemery

    added a commit that references this issue on Mar 4, 2026

    chore: Remove redundant type (#1421)

    ...

    082761e
11. abbiemery

    closed this as completedin #1421on Mar 4, 2026