[DiamondJoseph]

To be merged into main after #1122 rather than into #1122 just arranged for convenient review.

Adjusts handling of optional arguments in plan parameters to use the required field from the JsonSchema only instead of additionally explicitly allowing null as an argument. This makes the schema easier to read and automated tools should work better with it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (22b287d) to head (cfd9e6d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1124   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files          41       41           
  Lines        2555     2557    +2     
=======================================
+ Hits         2414     2416    +2     
  Misses        141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[DiamondJoseph]

I do not know why these changes have appeared here just from adjusting handling of | None, as they do not allow None or defaults... I have always been confused why they got set to integer 0 instead of float 0.0, and I think this is more correct but why!?

StrictConfig: ConfigDict = {"extra": "forbid", "arbitrary_types_allowed": True}

@dataclass(config=StrictConfig)
class Circle(Region[Axis]):
      [...]
      radius: float = Field(description="Radius of the circle", gt=0.0)

[tpoliaw]

I'm not sure what I think of int | None being treated differently to int | None = None but I can't think of a better way and this does make the schema more useful in the majority of cases.

[DiamondJoseph]

I'm not sure what I think of int | None being treated differently to int | None = None but I can't think of a better way and this does make the schema more useful in the majority of cases.

int | None = None -> This argument is optional, if you provide it it must be an int
int | None -> This argument is required and can be an int or None

Can I think of any examples where they are using the 2nd and shouldn't actually be using the first? Not right now. Not giving None a privileged default?

But if that is what your plan should have, cutting the possibility of passing None means you must pass an int.