Repository navigation
feat: Seperate debug and suspend behaviours; consolidate LDAP requirements - #1130
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1130 +/- ##
=======================================
Coverage 94.92% 94.92%
=======================================
Files 42 42
Lines 2717 2717
=======================================
Hits 2579 2579
Misses 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DiamondJoseph
changed the title
DiamondJoseph
changed the title
DiamondJoseph
force-pushed
the
internal-debug
branch
from
November 3, 2025 16:02
cdddfae to
62a1531
Compare
DiamondJoseph
force-pushed
the
internal-debug
branch
from
November 19, 2025 14:04
66f66a3 to
29d2a66
Compare
DiamondJoseph
force-pushed
the
internal-debug
branch
from
November 21, 2025 11:50
29d2a66 to
1f5cb3a
Compare
DiamondJoseph
changed the title
DiamondJoseph
force-pushed
the
internal-debug
branch
from
November 21, 2025 11:55
1f5cb3a to
6686848
Compare
DiamondJoseph
marked this pull request as ready for review
November 21, 2025 11:56
keithralphs
reviewed
Nov 25, 2025
keithralphs
left a comment
keithralphs
left a comment
Contributor
There was a problem hiding this comment.
See existing commenty re python path in Dockerfile
DiamondJoseph
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the container build to remove the debug container, and properly capture the requirements on the LDAP sidecar.
This container build has been used to debug using VSCode remote attaching to the container, or by port-forwarding from a local workstation.
The previous
debugbehaviour of suspending has been extracted into asuspendargument.