Repository navigation
Conversation
Contributor
|
Issues:
|
tpoliaw
force-pushed
the
uv_copier_update
branch
from
October 3, 2025 10:37
31887f4 to
e9fb90f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 41 41
Lines 2638 2638
=======================================
Hits 2499 2499
Misses 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tpoliaw
force-pushed
the
uv_copier_update
branch
3 times, most recently
from
October 3, 2025 13:02
81abb40 to
2b35608
Compare
tpoliaw
force-pushed
the
uv_copier_update
branch
from
October 15, 2025 14:44
2b35608 to
78b9411
Compare
Uses uv for python management
tpoliaw
force-pushed
the
uv_copier_update
branch
from
October 21, 2025 08:24
835eaaa to
2f4b970
Compare
Re-using the user's local cache means invalid links get created
Once the uv cache has been set up, configuring the pre-commit hooks takes the most significant amount of time building the container. Using a shared volume for the pre-commit cache as well takes the devcontainer re-build time from ~1m10s to ~10s.
Convenience trumps consistency This reverts commit 95b8c2e.
tpoliaw
force-pushed
the
uv_copier_update
branch
from
October 23, 2025 15:29
2f4b970 to
5cf85d6
Compare
DiamondJoseph
changed the title
DiamondJoseph
approved these changes
Oct 29, 2025
tpoliaw
commented
Oct 29, 2025
Comment on lines
+67
to
+84
| // Keep a persistent cross container cache for uv, pre-commit, and the venvs | ||
| { | ||
| "source": "persistent-uv-cache", | ||
| "target": "/root/.cache/uv", | ||
| "type": "volume" | ||
| }, | ||
| // ...and for pre-commit | ||
| { | ||
| "source": "persistent-pre-commit-cache", | ||
| "target": "/root/.cache/pre-commit", | ||
| "type": "volume" | ||
| } | ||
| // Use a volume mount for the uv venv so it is local to the container | ||
| { | ||
| "target": "/workspaces/${localWorkspaceFolderBasename}/.venv", | ||
| "source": "devcontainer-shared-cache", | ||
| "type": "volume" | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This has been changed upstream to use a single cache for everything, do we want to keep in sync with that?
Contributor
Author
There was a problem hiding this comment.
Actually, with the envvars set above this does need to change one way or the other
DiamondJoseph
added a commit
that referenced
this pull request
Dec 5, 2025
Contributor
|
Duplicate of #1290 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses uv for python management