Skip to content

refactor: Move numtracker into utils package - #1352

Merged
tpoliaw merged 1 commit into
mainfrom
numtracker-move
Jan 27, 2026
Merged

tpoliaw merged 1 commit into
mainfrom
numtracker-move

Conversation

@tpoliaw

@tpoliaw tpoliaw commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

The numtracker is not used by the client.

The numtracker is not used by the client.
@tpoliaw
tpoliaw requested a review from a team as a code owner January 26, 2026 12:06
@codecov

codecov Bot commented Jan 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.00%. Comparing base (ff433a8) to head (d5f88b3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1352   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files          42       42           
  Lines        2765     2765           
=======================================
  Hits         2627     2627           
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw tpoliaw changed the title Move numtracker from client package into utils refactor: Move numtracker from client package into utils Jan 26, 2026
@tpoliaw tpoliaw changed the title refactor: Move numtracker from client package into utils refactor: Move numtracker into utils package Jan 26, 2026
@ZohebShaikh

ZohebShaikh commented Jan 27, 2026 •

Copy link
Copy Markdown
Contributor

authentication.py is in service folder because it is used by both client and server, Is this correct ?

Clicked the wrong button

@ZohebShaikh ZohebShaikh reopened this Jan 27, 2026
@tpoliaw

tpoliaw commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

I'm not sure about service vs utils although I would have imagined service would be more server focussed. We can move auth later if we decide it needs it. This move was prompted by wanting to make BlueapiClient usable as blueapi.client.BlueapiClient instead of blueapi.client.client.BlueapiClient which created circular imports with numtracker in the client.

@tpoliaw
tpoliaw merged commit 8838efb into main Jan 27, 2026
34 of 35 checks passed
@tpoliaw
tpoliaw deleted the numtracker-move branch January 27, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants