Skip to content

feat: Checkout tags as well as branches when cloning into scratch - #1482

Merged
tpoliaw merged 6 commits into
mainfrom
checkout-tag
Apr 22, 2026
Merged

tpoliaw merged 6 commits into
mainfrom
checkout-tag

Conversation

@tpoliaw

@tpoliaw tpoliaw commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

The branch field in the config file can now be set to the value of a
tag. While it could be confusing to use 'branch' for both, it mirrors
the behaviour of the --branch flag when cloning repositories with the
git CLI.

In a slight change in behaviour, the branch field is now only used when
first cloning a repository - if it already exists in the scratch area it
will be left in the same state. This is to avoid the ambiguity of how
tags should behave when the repo has been modified since being cloned.

@tpoliaw
tpoliaw requested a review from a team as a code owner April 10, 2026 14:00
@codecov

codecov Bot commented Apr 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.24%. Comparing base (b2c927f) to head (841930b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1482      +/-   ##
==========================================
- Coverage   95.25%   95.24%   -0.01%     
==========================================
  Files          43       43              
  Lines        3159     3156       -3     
==========================================
- Hits         3009     3006       -3     
  Misses        150      150              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZohebShaikh ZohebShaikh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good only few suggestions

Comment thread helm/blueapi/config_schema.json Resolved
Comment thread src/blueapi/cli/scratch.py Resolved
@tpoliaw
tpoliaw requested a review from dan-fernandes April 15, 2026 13:47
@ZohebShaikh
ZohebShaikh self-requested a review April 15, 2026 14:12
@tpoliaw
tpoliaw merged commit a7cb17f into main Apr 22, 2026
18 checks passed
@tpoliaw
tpoliaw deleted the checkout-tag branch April 22, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants