Skip to content

refactor: Use Depends injection to extract user name - #1495

Merged
tpoliaw merged 1 commit into
mainfrom
depends-user
Jun 23, 2026
Merged

tpoliaw merged 1 commit into
mainfrom
depends-user

Conversation

@tpoliaw

@tpoliaw tpoliaw commented Apr 17, 2026 •

Copy link
Copy Markdown
Contributor

And split the auth check into two so that other methods can access the
raw bearer token if required.

@tpoliaw
tpoliaw requested a review from a team as a code owner April 17, 2026 15:21
@tpoliaw
tpoliaw requested a review from shree-iyengar-dls May 19, 2026 16:55
@tpoliaw
tpoliaw marked this pull request as draft May 27, 2026 10:26
@tpoliaw
tpoliaw changed the base branch from main to auth-checks May 29, 2026 10:48
@codecov

codecov Bot commented May 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.70%. Comparing base (38f0d89) to head (36f077c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1495   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files          43       43           
  Lines        3240     3240           
=======================================
  Hits         3101     3101           
  Misses        139      139           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw tpoliaw changed the title Use Depends injection to extract user name refactor: Use Depends injection to extract user name Jun 1, 2026
@tpoliaw
tpoliaw marked this pull request as ready for review June 2, 2026 16:03
@tpoliaw
tpoliaw requested a review from ZohebShaikh June 2, 2026 16:04
Comment thread src/blueapi/service/authentication.py Resolved
Base automatically changed from auth-checks to main June 23, 2026 14:10
@tpoliaw
tpoliaw added this pull request to the merge queue Jun 23, 2026
Merged via the queue into main with commit cc514f5 Jun 23, 2026
19 checks passed
@tpoliaw
tpoliaw deleted the depends-user branch June 23, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants