Skip to content

chore!: Remove dodal dependency - #1534

Merged
abbiemery merged 16 commits into
mainfrom
dodal-ectomy
Jun 24, 2026
Merged

abbiemery merged 16 commits into
mainfrom
dodal-ectomy

Conversation

@tpoliaw

@tpoliaw tpoliaw commented May 1, 2026 •

Copy link
Copy Markdown
Contributor

Remove DeviceSource and DodalSource and patch up tests

@codecov

codecov Bot commented May 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.44%. Comparing base (ab2ebc6) to head (047ec9d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1534      +/-   ##
==========================================
- Coverage   95.61%   95.44%   -0.17%     
==========================================
  Files          43       42       -1     
  Lines        3214     3140      -74     
==========================================
- Hits         3073     2997      -76     
- Misses        141      143       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw tpoliaw changed the title Remove dodal dependency chore!: Remove dodal dependency May 1, 2026
@tpoliaw
tpoliaw marked this pull request as ready for review May 5, 2026 10:06
@tpoliaw
tpoliaw requested a review from a team as a code owner May 5, 2026 10:06
@tpoliaw
tpoliaw requested a review from ZohebShaikh June 1, 2026 13:22

@abbiemery abbiemery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tpoliaw
tpoliaw added this pull request to the merge queue Jun 24, 2026
@abbiemery
abbiemery removed this pull request from the merge queue due to a manual request Jun 24, 2026
@abbiemery
abbiemery added this pull request to the merge queue Jun 24, 2026
Merged via the queue into main with commit 707abfb Jun 24, 2026
19 checks passed
@abbiemery
abbiemery deleted the dodal-ectomy branch June 24, 2026 12:56
dan-fernandes pushed a commit to dan-fernandes/blueapi that referenced this pull request Jul 7, 2026
)

After removing dodal as dependency in DiamondLightSource#1534. It becomes difficult for
village blueapi to install their plans etc because scratch does install
with no dependencies. To make the release usable again we are removing
the flag, while we figure out a long term solution for this problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants