Skip to content

feat: add logout method to client #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZohebShaikh merged 3 commits into from
Aug 17, 2026
Merged

feat: add logout method to client #1630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecbb46b
feat: add logout
ZohebShaikh Aug 17, 2026
5b48e88
Merge branch 'client-login' into add-logout
ZohebShaikh Aug 17, 2026
d7b3315
add test
ZohebShaikh Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/blueapi/client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,6 +775,11 @@ def login(self, token_path: Path | None = None):
else:
print("Server is not configured to use authentication!")

def logout(self):
if sm := self._rest.session_manager:
sm.logout()
self._rest.session_manager = None


class PlanFailedError(Exception):
def __init__(self, typ: str, message: str):
Expand Down
10 changes: 10 additions & 0 deletions tests/unit_tests/client/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,3 +1000,13 @@ def test_client_login_no_oidc(
client.login()

mock_session_manager.assert_not_called()


def test_client_logout(mock_rest: Mock, client: BlueapiClient):
mock_session_manager = Mock()
mock_rest.session_manager = mock_session_manager

client.logout()

mock_session_manager.logout.assert_called_once()
assert mock_rest.session_manager is None