Skip to content

refactor: replace tomlkit with stdlib tomllib - #1664

Merged
ZohebShaikh merged 1 commit into
mainfrom
is_tomlib-required
Nov 9, 2026
Merged

ZohebShaikh merged 1 commit into
mainfrom
is_tomlib-required

Conversation

@ZohebShaikh

@ZohebShaikh ZohebShaikh commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1746

@ZohebShaikh
ZohebShaikh requested a review from a team as a code owner September 10, 2026 16:16
@codecov

codecov Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.47%. Comparing base (5884bfd) to head (53749ef).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1664   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files          49       49           
  Lines        3804     3804           
=======================================
  Hits         3670     3670           
  Misses        134      134           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw

tpoliaw commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Where is this name being used? In reporting the environment? If the main goal is to get rid of the tomlkit dependency, now we're on 3.11+ there is tomllib in the standard library.

@ZohebShaikh ZohebShaikh reopened this Nov 9, 2026
@ZohebShaikh ZohebShaikh changed the title refactor: use directory name instead of pypi name refactor: replace tomlkit with stdlib tomllib Nov 9, 2026
@ZohebShaikh
ZohebShaikh added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 1908cff Nov 9, 2026
22 checks passed
@ZohebShaikh
ZohebShaikh deleted the is_tomlib-required branch November 9, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove tomlkit dependency

2 participants