Repository navigation
ci: only publish container and Helm chart when all checks pass - #1711
Closed
ZohebShaikh wants to merge 1 commit into
Closed
ZohebShaikh wants to merge 1 commit into
ZohebShaikh wants to merge 1 commit into
Conversation
Gate publish on lint and system-test as well as test, skip helm_publish when publish is false, and drop the unused metadata step that read undefined env vars. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1711 +/- ##
=======================================
Coverage 96.41% 96.41%
=======================================
Files 49 49
Lines 3711 3711
=======================================
Hits 3578 3578
Misses 133 133 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
containernow waits forlintandsystem-testas well astest, andpublishis true only when all three pass. Before, a tag with failing lint or system tests still published the image and chart.helm_publishnow checksinputs.publish. Before, a tag with failing tests skipped the image push but still pushed a chart pointing at that missing image.Extract metadatastep fromhelm_publish: it read the undefinedenv.REGISTRY/env.IMAGE_NAMEand nothing used its outputs.Trade-off: the container build now starts after system tests finish rather than after unit tests.
Will conflict with #1709 on the line next to
needs:inci.yml; whichever merges second keeps both changes.Test plan
publishfalse)🤖 Generated with Claude Code