Skip to content

fix: Add --verify=false to helm plugin install helm-values-schema-json, and update example-services - #1722

Merged
dan-fernandes merged 2 commits into
mainfrom
skip-helm-plugin-verification
Oct 26, 2026
Merged

dan-fernandes merged 2 commits into
mainfrom
skip-helm-plugin-verification

Conversation

@dan-fernandes

Copy link
Copy Markdown
Contributor

t looks like the "ubuntu-latest" github runner was upgraded to Ubuntu 26.04, and now comes with helm4 pre-installed.

Plugin verification was introduced in helm 4, which I don't think helm-values-schema-json.

@dan-fernandes
dan-fernandes requested a review from a team as a code owner October 26, 2026 11:22
@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.46%. Comparing base (eff0e50) to head (385e4cf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1722   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files          49       49           
  Lines        3791     3791           
=======================================
  Hits         3657     3657           
  Misses        134      134           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dan-fernandes dan-fernandes changed the title Add --verify=false to helm plugin install helm-values-schema-json fix:Add --verify=false to helm plugin install helm-values-schema-json Oct 26, 2026
@dan-fernandes dan-fernandes changed the title fix:Add --verify=false to helm plugin install helm-values-schema-json fix: Add --verify=false to helm plugin install helm-values-schema-json Oct 26, 2026

@oliwenmandiamond oliwenmandiamond left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to have fixed issue. Thank you!

@dan-fernandes dan-fernandes changed the title fix: Add --verify=false to helm plugin install helm-values-schema-json fix: Add --verify=false to helm plugin install helm-values-schema-json, and update example-services Oct 26, 2026
@dan-fernandes
dan-fernandes added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit 307498a Oct 26, 2026
21 of 22 checks passed
@dan-fernandes
dan-fernandes deleted the skip-helm-plugin-verification branch October 26, 2026 11:48
ZohebShaikh pushed a commit that referenced this pull request Nov 2, 2026
…n, and update example-services (#1722)

t looks like the "ubuntu-latest" github runner was upgraded to Ubuntu
26.04, and now comes with [helm4
pre-installed](https://github.com/actions/runner-images/blob/1c4d727f58d448da7f0e975c5fdb16e0459e1d3c/images/ubuntu/Ubuntu2604-Readme.md?plain=1#L33).

Plugin verification was introduced in helm 4, which I don't think
helm-values-schema-json.
ZohebShaikh pushed a commit that referenced this pull request Nov 2, 2026
…n, and update example-services (#1722)

t looks like the "ubuntu-latest" github runner was upgraded to Ubuntu
26.04, and now comes with [helm4
pre-installed](https://github.com/actions/runner-images/blob/1c4d727f58d448da7f0e975c5fdb16e0459e1d3c/images/ubuntu/Ubuntu2604-Readme.md?plain=1#L33).

Plugin verification was introduced in helm 4, which I don't think
helm-values-schema-json.
ZohebShaikh pushed a commit that referenced this pull request Nov 9, 2026
…n, and update example-services (#1722)

t looks like the "ubuntu-latest" github runner was upgraded to Ubuntu
26.04, and now comes with [helm4
pre-installed](https://github.com/actions/runner-images/blob/1c4d727f58d448da7f0e975c5fdb16e0459e1d3c/images/ubuntu/Ubuntu2604-Readme.md?plain=1#L33).

Plugin verification was introduced in helm 4, which I don't think
helm-values-schema-json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants