Repository navigation
fix: Ignore missing task ID when removing from _pending - #1735
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1735 +/- ##
==========================================
- Coverage 96.37% 96.31% -0.06%
==========================================
Files 50 50
Lines 3831 3831
==========================================
- Hits 3692 3690 -2
- Misses 139 141 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
As the _current task is not cleared until it is overwritten when the next task starts and the killsignal handling goes through the same task handling logic as 'normal' tasks, the task would be removed from the pending list twice, failing the second time around. Given the worker is shutting down at that point it doesn't matter if the exception is raised, it's just an annoyance to have the false-positive error logged. There is more work to be done in this area around when the current task is cleared and when it is removed from pending but should be a new change in its own right.
tpoliaw
force-pushed
the
shutdown-error-log
branch
from
November 11, 2026 17:11
e14c525 to
9b64d83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the _current task is not cleared until it is overwritten when the
next task starts and the killsignal handling goes through the same task
handling logic as 'normal' tasks, the task would be removed from the
pending list twice, failing the second time around.
Given the worker is shutting down at that point it doesn't matter if the
exception is raised, it's just an annoyance to have the false-positive
error logged.
There is more work to be done in this area around when the current task
is cleared and when it is removed from pending but should be a new
change in its own right.