Skip to content

chore: Increase the default ephemeral storage request #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZohebShaikh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Increase the default ephemeral storage request #1759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm/blueapi/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ A Helm chart deploying a worker pod that runs Bluesky plans
| podLabels | object | `{}` | |
| podSecurityContext | object | `{}` | |
| readinessProbe | object | `{"failureThreshold":2,"httpGet":{"path":"/healthz","port":"http"},"periodSeconds":10}` | Readiness probe, if configured kubernetes will not route traffic to this pod if failed consecutively. This could allow the service time to recover if it is being overwhelmed by traffic, but without the to ability to load balance or scale up/outwards, upstream services will need to know to back off. This is automatically disabled when in debug mode. |
| resources | object | `{"limits":{"cpu":"2000m","memory":"4000Mi"},"requests":{"cpu":"200m","memory":"400Mi"}}` | Sets the compute resources available to the pod. These defaults are appropriate when using debug mode or an internal PVC and therefore running VS Code server in the pod. In the Diamond cluster, requests must be >= 0.1*limits When not using either of the above, the limits may be lowered. When idle but connected, blueapi consumes ~400MB of memory and 1% cpu and may struggle when allocated less. |
| resources | object | `{"limits":{"cpu":"2000m","ephemeral-storage":"8Gi","memory":"4000Mi"},"requests":{"cpu":"200m","ephemeral-storage":"4Gi","memory":"400Mi"}}` | Sets the compute resources available to the pod. These defaults are appropriate when using debug mode or an internal PVC and therefore running VS Code server in the pod. In the Diamond cluster, requests must be >= 0.1*limits When not using either of the above, the limits may be lowered. When idle but connected, blueapi consumes ~400MB of memory and 1% cpu and may struggle when allocated less. |
| restartOnConfigChange | bool | `true` | If enabled the blueapi pod will restart on changes to `worker` |
| securityContext.runAsNonRoot | bool | `true` | |
| securityContext.runAsUser | int | `1000` | |
Expand Down
6 changes: 6 additions & 0 deletions helm/blueapi/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,9 @@
"cpu": {
"type": "string"
},
"ephemeral-storage": {
"type": "string"
},
"memory": {
"type": "string"
}
Expand All @@ -222,6 +225,9 @@
"cpu": {
"type": "string"
},
"ephemeral-storage": {
"type": "string"
},
"memory": {
"type": "string"
}
Expand Down
2 changes: 2 additions & 0 deletions helm/blueapi/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,11 @@ resources:
limits:
cpu: 2000m
memory: 4000Mi
ephemeral-storage: 8Gi
requests:
cpu: 200m
memory: 400Mi
ephemeral-storage: 4Gi

# -- Override resources for init container. By default copies resources of main container.
initResources: {}
Expand Down
2 changes: 2 additions & 0 deletions tests/unit_tests/test_helm_chart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,12 @@
"requests": {
"cpu": "10000m",
"memory": "100Gi",
"ephemeral-storage": "100Gi",
},
"limits": {
"cpu": "20000m",
"memory": "200Gi",
"ephemeral-storage": "200Gi",
},
}

Expand Down
Loading