Skip to content

i15-1: Add centring result to data collection metadata - #152

Closed
jacob-williamson wants to merge 8 commits into
mainfrom
xtal_bluesky_188_centring_result_in_metadata
Closed

jacob-williamson wants to merge 8 commits into
mainfrom
xtal_bluesky_188_centring_result_in_metadata

Conversation

@jacob-williamson

@jacob-williamson jacob-williamson commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

@jacob-williamson jacob-williamson changed the title Xtal bluesky 188 centring result in metadata i15-1: Add centring result to data collection metadata Oct 20, 2026
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.68%. Comparing base (656da67) to head (677cc10).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   98.67%   98.68%           
=======================================
  Files          23       23           
  Lines        1287     1295    +8     
=======================================
+ Hits         1270     1278    +8     
  Misses         17       17           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. I feel like this might be worth revisiting again with Richard, sorry. I think the best architecture is that all blueapi calls associated with the experiment (including robot load) get put in tiled and associated together there. Analysis also puts results in there (associated with the centring) so to look up why we centred where we did we do a tiled query of "data collection" -> "associated centring" -> "result". I think it's worth investigating that rather than doign this given it's probably not urgent anyway.

@jacob-williamson

Copy link
Copy Markdown
Collaborator Author

Discussed IRL with @DominicOram and @RJCD-Diamond, closing in favour of linking centrings and data collections in tiled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i15-1: Write sample centring result to nexus/tiled

2 participants