Repository navigation
i15-1: Add centring result to data collection metadata - #152
jacob-williamson wants to merge 8 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
=======================================
Coverage 98.67% 98.68%
=======================================
Files 23 23
Lines 1287 1295 +8
=======================================
+ Hits 1270 1278 +8
Misses 17 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DominicOram
left a comment
There was a problem hiding this comment.
Hmm.. I feel like this might be worth revisiting again with Richard, sorry. I think the best architecture is that all blueapi calls associated with the experiment (including robot load) get put in tiled and associated together there. Analysis also puts results in there (associated with the centring) so to look up why we centred where we did we do a tiled query of "data collection" -> "associated centring" -> "result". I think it's worth investigating that rather than doign this given it's probably not urgent anyway.
|
Discussed IRL with @DominicOram and @RJCD-Diamond, closing in favour of linking centrings and data collections in tiled |
Fixes DiamondLightSource/crystallography-bluesky#188 with DiamondLightSource/crystallography-bluesky#192