Repository navigation
Publish the chart only when the container image was pushed - #12
Merged
Merged
Conversation
The helm job waited only for test, so on a tag a failed image build still published a chart whose default image tag did not exist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CCtPFejfd3WP589miPqaL3
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=======================================
Coverage 61.64% 61.64%
=======================================
Files 3 3
Lines 219 219
=======================================
Hits 135 135
Misses 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
helmjob waited only fortestand ran alongsidecontainer. So on a tag, a failed image build or push still published chart X.Y.Z, whose default imagedls-tiled:X.Y.Zdid not exist. The job now needscontainerand only publishes ifcontainersucceeded.🤖 Generated with Claude Code
https://claude.ai/code/session_01CCtPFejfd3WP589miPqaL3