Repository navigation
Bin the RGB diodes beside the camera in /binned - #24
Merged
hyperrealist merged 1 commit intoOct 19, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 95.35% 95.49% +0.13%
==========================================
Files 5 5
Lines 775 799 +24
==========================================
+ Hits 739 763 +24
Misses 36 36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
/binned answers DiodesRed/DiodesGreen/DiodesBlue next to the camera's RedTotal/GreenTotal/BlueTotal, on the same bins, or null for a run without diodes. They are read from primary/spectroscopy_diodes-<colour> or primary/<colour> (fly scans: the PandA's per-frame means), else from the step scan's event table, primary/internal/spectroscopy_diodes-<colour>. The diodes take no part in reconciling lengths: a second PandA lagging behind never holds the camera images back, and its image keeps the points it has. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BsMDFhupHcBFbVJPK8QAvR
hyperrealist
force-pushed
the
diode-channels
branch
from
October 19, 2026 11:39
e9060e2 to
d0d252d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/binnedalso returns the RGB diodes, asDiodesRed/DiodesGreen/DiodesBlueon the camera's bins, so the UI can switch between camera and diodes (DiamondLightSource/atlas#235). It's additive:RedTotal/GreenTotal/BlueTotalare unchanged, and a run without diodes answersnullfor them.The diodes are read from
primary/spectroscopy_diodes-<colour>orprimary/<colour>(fly scans, the PandA's per-frame means), else from the step scan's event tableprimary/internal/spectroscopy_diodes-<colour>. They don't take part in reconciling lengths, so a lagging PandA never holds the camera images back.Testing
tox, with new tests for fly, step (a real event table), lagging diodes, the scan grid and runs without diodes.cb4c7fc4(fly) anddbc25a90(step) in a local server: the diode images match numpy's binning on the same edges. A recent run without diodes answersnull.🤖 Generated with Claude Code
https://claude.ai/code/session_01BsMDFhupHcBFbVJPK8QAvR