Repository navigation
Draw the RGB diodes in /render too - #25
Merged
Merged
Conversation
/render's JSON now has DiodesRed/DiodesGreen/DiodesBlue beside the camera's channels, drawn the same way in every kind, and null for a run without diodes; format=png takes them as a channel (404 for a run without them). Where the diodes are behind the camera they draw nothing, and grid cells leave out points without a finite value instead of averaging in NaN. Dropping points without a position failed with a 500 when a diode channel was shorter than the positions; it now masks such a channel by its length, as the slice mask already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BsMDFhupHcBFbVJPK8QAvR
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 95.49% 95.55% +0.06%
==========================================
Files 5 5
Lines 799 810 +11
==========================================
+ Hits 763 774 +11
Misses 36 36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/rendernow drawsDiodesRed/DiodesGreen/DiodesBluebeside the camera's channels in every kind (nullfor a run without diodes), so the ViSR plot types other than the setpoint grid can show the diodes.format=pngaccepts them aschanneltoo.Also fixes a 500 in
/binnedand/renderwhen a run has points without a position and its diodes are behind the camera.To test:
/api/v1/render/<uid>?kind=rectangleson a run with diodes returnschannels.DiodesRed; on one without, it isnull.🤖 Generated with Claude Code
https://claude.ai/code/session_01BsMDFhupHcBFbVJPK8QAvR